-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return Error if CKZG or BLS features are disabled, but are called. #1435
Comments
Hi, willing to work on this. Can you share some pointers please? |
Sure, in revm-precompile lib.rs, instead of conditionally adding precompiles with cfg, they should always be added but with a fallback implementation that panics at runtime. For example in cancun revm/crates/precompile/src/lib.rs Lines 140 to 158 in 30c6362
the extend should always be enabled, and |
Would not panic on those. Seems like bad behaviour |
Renamed the issue, we should return the error on this. |
We should modify Would add something like:
Fatal error would stop execution, while Ok and Error would work as previously with |
ref: #1283 |
Implemented for kzg here: #1589 |
The precompile address should be specified regardless, but with an implementation that panics at run time so that certain bugs are caught early.
The text was updated successfully, but these errors were encountered: