Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: accept offer #280

Closed
wants to merge 104 commits into from
Closed

Conversation

FrancoAguzzi
Copy link
Contributor

@FrancoAguzzi FrancoAguzzi commented Apr 8, 2024

feat: swap confirmation modal for accepting swaps #269

FrancoAguzzi and others added 30 commits March 12, 2024 15:28
- added the grid sizes to the card
- added a new type called `isConfirmationModal` for confirmations when creating swaps in the swap station and when confirming accept swaps in swap offers. This boolean will define a single line of 5 squares
- changed the laptop/desktop squares from 4 to 3. They were being overflowed/cutted from the frame
- commented the entire placeholder code/logic
- removed unnecessary Math when calculating emptySquaresCount
- fixed overflows on offerSummary, hidden for X and auto for Y
- fixed gap for mobile-s (was cutting out of the frame)
- removed the scroll from the grids in all the offerSummary
fix: grid not showing in swap confirmation modal
- removed dashes from fill-rule and clip-rule

Co-authored-by: frankind.eth <49823133+FrancoAguzzi@users.noreply.github.com>
- duplicated check on address

Co-authored-by: frankind.eth <49823133+FrancoAguzzi@users.noreply.github.com>
Co-authored-by: frankind.eth <49823133+FrancoAguzzi@users.noreply.github.com>
…ddress-external-link

Feat/display address external link
heronlancellot and others added 27 commits April 1, 2024 14:14
feat: fetch ponder data, display as tokenCard and further confirm the swap
Co-authored-by: frankind.eth <49823133+FrancoAguzzi@users.noreply.github.com>
Obs: Expiry not working yet
…-not-showing-up

make the add Token button show up again
the user is sgined in with the wallet.
removed dev logs.
feat: Pagination with ponder and react query
Copy link

vercel bot commented Apr 8, 2024

@FrancoAguzzi is attempting to deploy a commit to the Shared Blockful's projects Team on Vercel.

A member of the Team first needs to authorize it.

setFailedLoadingImage(true);
}
}
}, [avatarQueryStatus]);

Check warning

Code scanning / ESLint

verifies the list of dependencies for Hooks like useEffect and similar Warning

React Hook useEffect has a missing dependency: 'avatarSrc'. Either include it or remove the dependency array.
@@ -98,6 +99,10 @@
checkForTokenApproval(token);
}, []);

useEffect(() => {
checkForTokenApproval(token);
}, [chain, token, authenticatedUserAddress]);

Check warning

Code scanning / ESLint

verifies the list of dependencies for Hooks like useEffect and similar Warning

React Hook useEffect has a missing dependency: 'checkForTokenApproval'. Either include it or remove the dependency array.
@@ -35,7 +34,7 @@
setAuthenticatedUserTokensList([]);
setSearchedUserTokensList([]);
setInputAddress("");
}, [chain]);
}, [chain, authenticatedUserAddress]);

Check warning

Code scanning / ESLint

verifies the list of dependencies for Hooks like useEffect and similar Warning

React Hook useEffect has missing dependencies: 'setAuthenticatedUserTokensList', 'setInputAddress', and 'setSearchedUserTokensList'. Either include them or remove the dependency array.
Comment on lines +87 to +93
}, [
address,
isNetworkSupported,
authenticatedUserAddress,
validatedAddressToSwap,
destinyChain,
]);

Check warning

Code scanning / ESLint

verifies the list of dependencies for Hooks like useEffect and similar Warning

React Hook useEffect has a missing dependency: 'getUserTokens'. Either include it or remove the dependency array.

useEffect(() => {
updateCreateSwapApprovedTokensCount(0);
}, [authenticatedUserTokensList]);

Check warning

Code scanning / ESLint

verifies the list of dependencies for Hooks like useEffect and similar Warning

React Hook useEffect has a missing dependency: 'updateCreateSwapApprovedTokensCount'. Either include it or remove the dependency array.
isFetchingNextPage: false,
hasNextPage: false,
isLoadingOffersQuery: false,
acceptSwapOffer: () => {},

Check failure

Code scanning / ESLint

Disallow empty functions Error

Unexpected empty method 'acceptSwapOffer'.
acceptSwapOffer: () => {},
swapOfferToAccept: null,
approvedTokensCount: 0,
setApprovedTokensCount: () => {},

Check failure

Code scanning / ESLint

Disallow empty functions Error

Unexpected empty method 'setApprovedTokensCount'.
}

setDisplayableData(displayableData);
}, [tokenData]);

Check warning

Code scanning / ESLint

verifies the list of dependencies for Hooks like useEffect and similar Warning

React Hook useEffect has a missing dependency: 'tokenDisplayableData'. Either include it or remove the dependency array.

useEffect(() => {
offersQueries && processSwaps();
}, [offersQueries]);

Check warning

Code scanning / ESLint

verifies the list of dependencies for Hooks like useEffect and similar Warning

React Hook useEffect has a missing dependency: 'processSwaps'. Either include it or remove the dependency array.
@@ -88,9 +99,13 @@
}
};

useEffect(() => {
clearSwapData();
}, []);

Check warning

Code scanning / ESLint

verifies the list of dependencies for Hooks like useEffect and similar Warning

React Hook useEffect has a missing dependency: 'clearSwapData'. Either include it or remove the dependency array.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants