-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: grid not showing in swap confirmation modal #226
Conversation
- added the grid sizes to the card - added a new type called `isConfirmationModal` for confirmations when creating swaps in the swap station and when confirming accept swaps in swap offers. This boolean will define a single line of 5 squares - changed the laptop/desktop squares from 4 to 3. They were being overflowed/cutted from the frame - commented the entire placeholder code/logic - removed unnecessary Math when calculating emptySquaresCount - fixed overflows on offerSummary, hidden for X and auto for Y - fixed gap for mobile-s (was cutting out of the frame) - removed the scroll from the grids in all the offerSummary
@0xneves is attempting to deploy a commit to the Shared Blockful's projects Team on Vercel. A member of the Team first needs to authorize it. |
hey yo @0xneves ! I can't test for some reason IDk with the GH the PR.. probably because you made by your I would like to add in TokenLists that:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
@0xneves By the way, I wasn't able to test as well. But it looks OK from the code perspective |
@@ -11,44 +11,62 @@ interface TokenCardsPlaceholderProps { | |||
desktopTotalSquares?: number; | |||
tabletTotalSquares?: number; | |||
mobileTotalSquares?: number; | |||
confirmationModalTotalSquares?: number; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logic is looking pretty complex. I will approve this PR now since I understand that refactoring it would be more painful than what we can handle atm. Let's come back to this logic later and rethink some things.
Bug Fixes
TL;DR
Changes:
isConfirmationModal
for confirmations when creating swaps in the swap station and when confirming accept swaps in swap offers. This boolean will define a single line of 5 squares