Get monitor up to speed again #3633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recenty, a price node got removed. Unfortunately, this node has been the first in the list of configured price nodes in the monitor configuration. A misplaced catch block caused the loop to stop instead of trying the next configured price node in the list.
Up until now, the monitor always chose the price nodes in their configured order. This resulted in querying always the same node and thus, create a bigger system load for this very node. Only in case of a failure, the monitor moved on to another node. Shuffling the list of nodes prior to querying provides at least some load balancing for the price nodes.
The format of the market API response changed. Formerly, there has been one line, now it is pretty print json.
Add the relatively new RefundAgent message to the monitor.
Observed, that a timeout of one minute works better than the original 90 seconds.
|
changes are live at monitor.bisq.network |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been some changes to the Bisq infrastructure recently, which not been reflected in the monitor so far:
These changes broke part of the Trading Stats and Dashboard dashboards, respectively.
some other minor improvements have been made as well.