RRF: add support for sending gcode checksums #2250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digant73
reviewed
Nov 17, 2021
This was referenced Nov 18, 2021
digant73
added a commit
to digant73/BIGTREETECH-TouchScreenFirmware
that referenced
this pull request
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
No new requirements.
Testing help on Marlin and other firmware beside RRF would be appreciated.
Description
When the firmware type is not yet detected, or RRF, send gcode commands with checksums.
Background:
RepRapFirmware 3.4beta4 changed the behavior of checksum handling and now works best when all host gcode is sent with checksums.
Benefits
Allows using checksum-mode on RRF in 3.4beta4 and later.
PR Status
Ready to merge pending code review and testing on other firmware.
Testing
Verified to work on my MKS TFT28 with RRF 3.3 (I have not yet updated my printers to 3.4 betas)