Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Progress Reporting with RRF #2547

Closed
Wombat37 opened this issue Jun 29, 2022 · 18 comments · Fixed by #2580
Closed

No Progress Reporting with RRF #2547

Wombat37 opened this issue Jun 29, 2022 · 18 comments · Fixed by #2580
Labels
bug Something isn't working

Comments

@Wombat37
Copy link

Somewhere along the way, the % Progress stopped being reported on my TFT35 E3 V3.0 display coupled to a BTT E3 RRF V1.1 main board running RRF V3.3.11. The displayed progress remains at 0% during the course of the print as seen in the screen capture below.

No_Progress

I'm trying to track down which version introduced this bug. As I have to make a print each time I do this test, it's taking me some time to get this done. So far I've tested about 8 revisions and found that the problem was introduced between Sept 23 2021 (works) and April 1 2022 (doesn't work). I will narrow down the version as I test further. If anyone wants to suggest a version to try, let me know.

@Wombat37 Wombat37 added the bug Something isn't working label Jun 29, 2022
@Wombat37
Copy link
Author

OK, I've tracked down the apparent version that stopped the progress being reported under RRF.

Progress is reported using version 11/18/2021 (#2250)

Progress stops being reported in version 12/1/2021 (#2260)

I can't download the intervening versions as they give me a 404 error when trying to access them.

It looks like a lot of redundant settings (for RRF) were deleted from the config_rrf.ini file in the 12/1/2021 version. One of these settings could have been used as a flag to enable reporting progress.

I could start to selectively start restoring the configuration settings line by line but this would be a long process as I would need to set up a new print each time. It might be better to approach this from the code angle.

Hopefully, a quick workaround for this problem would be to restore one of the configuration settings.

I would welcome guidance on what to check next.

@digant73
Copy link
Contributor

digant73 commented Aug 14, 2022

@Wombat37 The binary for PR #2260 (with other PRs) was merged on 11/29/2021.
Try the binaries in the following zip file and let me know which is working or not.

BIGTREE_TFT35_V3.0_E3.27.x.zip

@Wombat37
Copy link
Author

Hi @digant73,

Thanks for looking into this.

I've been away for a few days but will now start to test the files you sent me. I've started with the 20111118 version but it's asking me to update the fonts, icons and config files too. Which ones should I be using? Should I be using these for all the other tests?

Thanks

@Wombat37
Copy link
Author

Wombat37 commented Aug 16, 2022

OK, in the interests of time, I tried to download these files. Looks like the code files are a bit picky about fonts, icons and config files.

I managed to get 20111118 running with fonts and icons from the Dec-01 pull request and the config_rrf.ini from the Nov-18 pull request :) I hope this is good for the tests you want.

As I need to print something to perform each test, it will take a day or two to complete all the tests. I'll keep you posted.

@digant73
Copy link
Contributor

digant73 commented Aug 16, 2022

The easy and correct way is to retrieve the content (binary, config.ini, icons etc...) browsing the repo history and retrieving only the releases reporting the description update prebuilt binaries and config (so the last update committed by bigtreetech providing the updated binaries).
Below an example where I highlighted two releases on 11-18-2021 and one release on 11-17-2021.
Download and test each release one by one. For each release, make the minimum changes on config.ini to be able to start a print (e.g. it is not important to enable features such as power loss recovery etc...).

repo_history

@Wombat37
Copy link
Author

I'm sorry but you must forgive me - I not very familiar with using this repository. To find previous builds, I've been looking at the closed Pull Requests. This is obviously not what I should be doing.

So where do I find the "repo history"? It's not obvious from the main GitHub page.

@kisslorand
Copy link
Contributor

kisslorand commented Aug 16, 2022

@Wombat37
Stay put, I am about to send you a TFT FW for testing, a FW based on the actual master .
https://mega.nz/file/mxQklbBL#f5wc9Gkarg3RnyMW6yYi1uffHCz8KRX8Leovi-NvoOg

You'll find a gcode file also for testing. That file doesn't print anything, doesn't move any axis, doesn't heat anything so you can use that file even without any filament loaded. It should just advance the progress.

@Wombat37
Copy link
Author

I assume you meant by "actual" master, the "current" master. I installed the latest build (15 days ago) and overwrote the binary with the file you supplied in your lost comment. I then ran the wait.gcode file from the RRF DWC webpage..

This gave an incrementing progress display from 0 to 100% and corresponding slide bar movement and ended with a "process aborted" message. I assume that this is what you were looking for.

Let me know what else I can do.

Thanks

@kisslorand
Copy link
Contributor

kisslorand commented Aug 16, 2022

I assume you meant by "actual" master, the "current" master.

Yes.

This gave an incrementing progress display from 0 to 100% and corresponding slide bar movement and ended with a "process aborted" message. I assume that this is what you were looking for.

Isn't this also what you were looking for?

Ah! I just saw the "process aborted" thing... Let me look into it.

@Wombat37
Copy link
Author

Sorry - yes I am but I don't know what's behind your test.

From your comment it looks like a fix is close.

Thanks

@kisslorand
Copy link
Contributor

Upon further testing It seems it is the RRF who gives the "Abort" message to the TFT.
The test gcode file was made just for testing the functionality of the progress.

As I said I am unfamiliar with RRF, so maybe something's missing from that gcode file that RRF expects. Maybe you can test it with a real gcode file... A really simple file would do it (ex one single line or circle).

@Wombat37
Copy link
Author

Ok - running a real test now - this is a 45 minute print but I should see the progress increment - I'll see if I get the abort message at the end.

I'll keep you posted.

Thanks for all your efforts - they're much appreciated!

@kisslorand
Copy link
Contributor

I am also thanking you for testing things. It's passed midnight here, so... tomorrow is another day.

@Wombat37
Copy link
Author

OK - have a good night!

In the meantime, all seems to be working properly - the progress is being reported correctly. I'll wait to see if the abort message appears and post back.

Thanks again

@Wombat37
Copy link
Author

OK - good news!

Everything seemed to work properly - the % progress and the sliding bar all incremented during the print and no abort message appeared at the end.

Thank you so much for fixing this useful feature.

@kisslorand
Copy link
Contributor

Fix is up: PR #2580

@Wombat37
Copy link
Author

Looks like you had to make some significant changes to the code to get this working. I'm surprised it took this much work to get something working again that worked before :)

Thank you again for all these efforts. They are much appreciated.

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants