Add new settings categories and clean up #1633

guruathwal · 2021-02-18T06:15:15Z

Add Marlin mode settings menu in screen settings.
Add Brightness settings menu in screen settings.
Remove some items from the Feature settings menu, which should only be configured through the config file.
Replace the word 'Simulator' with 'Emulator'.
Replace u8, u16, u32 with uint8_t, uint16_t, uint32_t.
Enable post-processor for displays with SSD1963 to reduce banding on some devices.
Move frequently polled commands to the top in parseACK.c

Build Report:

Device Variant	Old RAM Usage	New RAM usage	RAM Reduced	Old Flash Size	New Flash Size	Flash Size reduced
TFT35 V1.0	20728	20620	-108	144028	143164	-864
TFT35 V1.1	20728	20620	-108	144028	143164	-864
TFT35 V1.2	20728	20620	-108	143908	143044	-864
TFT35 V2	21520	21388	-132	153572	152624	-948
TFT35 V3.0	22028	21824	-204	171532	171028	-504
TFT35 E3 V3.0	22052	21848	-204	172200	171692	-508
TFT35 B1 V3.0	22052	21848	-204	172208	171700	-508
TFT43 V3.0	22052	21848	-204	172180	171684	-496
TFT50 V3.0	22052	21848	-204	172180	171684	-496
TFT70 V3.0	22180	21976	-204	173240	172744	-496
TFT28 V1.0	20728	20620	-108	144044	143188	-856
TFT28 V3.0	22052	21848	-204	172008	171504	-504
TFT24 V1.1	21952	21772	-180	167336	166980	-356
MKS TFT32 V1.4	22704	22536	-168	167596	166856	-740
MKS TFT28 V1.0	22704	22536	-168	167596	166856	-740

- Add Marlin mode settings menu in screen settings. - Add Brightness settings menu. in screen settings. - Remove some items from feature settings menu, which should only be configured through config file. - Replace the word 'Simulator' with 'Emulator'.

Update pin_TFT24_V1_1.h Update pin_MKS_TFT32_V1_4.h

…ScreenFirmware into dev

oldman4U · 2021-02-18T15:01:37Z

So there are no new Icons with this PR, right?

guruathwal · 2021-02-18T15:34:19Z

two icons are replaced

oldman4U · 2021-02-18T15:45:45Z

@Acenotass @AntoszHUN

The font and background colour icons are removed and there are 2 new icons for Marlin Mode and Brightness.

Could you please take care.

THANK YOU

AntoszHUN · 2021-02-18T16:20:46Z

@Acenotass @AntoszHUN

The font and background colour icons are removed and there are 2 new icons for Marlin Mode and Brightness.

Could you please take care.

THANK YOU

Again, he was unnecessarily changed because of a little nonsense. I don’t have time for this right now to edit icons unnecessarily again. I'm lying in bed. I caught the covid. Solve the stupidity. I'm getting out! You have to vary something with the icons and the menu every month. Do what you want. Hi!

sarvenn · 2021-02-18T18:01:35Z

Could you give more details for this item please?
"Remove some items from the Feature settings menu, which should only be configured through the config file."

Guilouz · 2021-02-18T19:39:50Z

Your icon Mesh_Editor for TFT43 is not centered :

10px on top, 7 px on bottom, 15px on left and 17px on right

Fixed :

mesh_editor.bmp.zip

Your icon Case_light for TFT43 does not fit with existing chamber icon :

Fixed :

case_light.bmp.zip

oldman4U · 2021-02-18T20:41:15Z

@Acenotass @AntoszHUN
The font and background colour icons are removed and there are 2 new icons for Marlin Mode and Brightness.
Could you please take care.
THANK YOU

Again, he was unnecessarily changed because of a little nonsense. I don’t have time for this right now to edit icons unnecessarily again. I'm lying in bed. I caught the covid. Solve the stupidity. I'm getting out! You have to vary something with the icons and the menu every month. Do what you want. Hi!

Hi Antosz.

Wish you the best. No reason to be rude.

Köszönöm

kisslorand · 2021-02-18T21:28:53Z

@AntoszHUN

I'm lying in bed. I caught the covid.

I wish you fast recovery! Stay away from stress and take care of your health.

traffic-light · 2021-02-18T22:26:20Z

@Acenotass @AntoszHUN
The font and background colour icons are removed and there are 2 new icons for Marlin Mode and Brightness.
Could you please take care.
THANK YOU

Again, he was unnecessarily changed because of a little nonsense. I don’t have time for this right now to edit icons unnecessarily again. I'm lying in bed. I caught the covid. Solve the stupidity. I'm getting out! You have to vary something with the icons and the menu every month. Do what you want. Hi!

I wish you the best! I hope you will have a fast recovery. And I hope you will get rid of all the covid symptoms (or how to call it...) I still have the problem that I'm quickly tired and trying to hurry on my bike is even worse ...

traffic-light · 2021-02-18T22:26:59Z

Could you give more details for this item please?
"Remove some items from the Feature settings menu, which should only be configured through the config file."

Touchme, invert axis and some more. So, pretty useless to configure easily trough the settings menu.

Take a look in the changed files.

… mode: change logic

radek8 · 2021-02-21T10:32:27Z

Patch tested.
You're right, now the M218 is working.
I misunderstood the principle of analyzing the interfaceCmd.c file
You have a little typo in the description

The E axis is still not correct in the set step length (M92)
see video
https://youtu.be/ZWL2C5YVrQY

radek8 · 2021-02-21T10:49:28Z

The different behavior is if I enter an integer or decimal with one, two, or 3 decimal places

https://youtu.be/vsdq-ljjGGg

radek8 · 2021-02-21T11:51:35Z

interfaceCmd.c uses the X_AXIS variable
and
parseACK.c uses the X_STEPPER variable
It's good?

guruathwal · 2021-02-21T12:26:57Z

@radek8 Line 527 should be cmd_float();. both _AXIS and _STEPPER are same thing with _STEPPER having extra E2_STEPPER

radek8

Please repair the Machine parametrs.c file
M913 T0 E% .0f \ n

{"M913 X%.0f\n", "M913 Y%.0f\n", "M913 Z%.0f\n", "M913 T0 E%.0f\n", "M913 T1 E%.0f\n"}, //TMC Hybrid Threshold Speed

digant73 · 2021-02-22T17:04:35Z

I would also optimize the parseAck moving on top of the "if then else" sequence all the periodically/frequently requested received status such as "FR", "Flow" etc.. and the prompt messages that could be received during a print such as "paused for user", "//action:" etc.. They are currently provided at the bottom so, they will match after performing hundreads of previous "if then else". The list must be arranged in order to have to most frequently used patterns on top and the least on the bottom (such as Capabilities and machine settings that are normally requested once at startup or in general when not printing)

radek8 · 2021-02-22T20:30:46Z

Hi
I found another problem with loading the Linear Advance parameter, for 2 extruders
After switching on, a zero value is always read, even though there is a valid value in eeprom. After editing, it will display well until the restart.
The problem is therefore in ParseACK.c
IntefaceCmd.c is fine.
It was loading properly after the restart before your intervention.
Don't want to revert to the original syntax?

M503 for one extruder

M503 for two extruders

digant73 · 2021-02-22T21:16:22Z

Remove "K" on line 657 of parseAck

enable post-processor for displays with SSD1963 to reduce banding on some devices.

radek8 · 2021-02-25T10:22:24Z

Remove "K" on line 657 of parseAck

Thank you

…ScreenFirmware into dev

bigtreetech · 2021-02-25T10:40:23Z

I think these are better to stay in the feature menu:
label_default_mode:Default Mode
label_fil_runout_inverting:Inverted Filament Runout Logic

May be necessary to put some common settings and non-common settings in different lists ?
for example

->0. Frequently-used settings
        ->1. Common settings
                ->2. File list mode
                ->2. filament sensor
->0. Not frequently-used settings
->0. System settings

The advantage of this is that users need not use SD to plug in the computer to modify the settings, and almost all the settings can be modified on the screen directly.
The disadvantage is that these label strings will take up a lot of memory flash

oldman4U · 2021-02-25T11:50:13Z

I think these are better to stay in the feature menu:
label_default_mode:Default Mode
label_fil_runout_inverting:Inverted Filament Runout Logic

May be necessary to put some common settings and non-common settings in different lists ?
for example
->0. Frequently-used settings
        ->1. Common settings
                ->2. File list mode
                ->2. filament sensor
->0. Not frequently-used settings
->0. System settings
The advantage of this is that users need not use SD to plug in the computer to modify the settings, and almost all the settings can be modified on the screen directly.
The disadvantage is that these label strings will take up a lot of memory flash

Based on which user/configuration will be defined what is common and what not? For me and just for me maybe, it is better to have a long list of settings but all of them available and at the same place than settings in different places based on more or less clear rules.

radek8 · 2021-02-25T17:00:33Z

I think these are better to stay in the feature menu:
label_default_mode:Default Mode
label_fil_runout_inverting:Inverted Filament Runout Logic

May be necessary to put some common settings and non-common settings in different lists ?
for example
->0. Frequently-used settings
        ->1. Common settings
                ->2. File list mode
                ->2. filament sensor
->0. Not frequently-used settings
->0. System settings
The advantage of this is that users need not use SD to plug in the computer to modify the settings, and almost all the settings can be modified on the screen directly.
The disadvantage is that these label strings will take up a lot of memory flash

I think it's a good idea.
A long list would be annoying. but I still want to have all the configuration options
If the "non frequently" and "system" menus could be hidden by the user, it would cater to users who configure printers for less experienced users and want to hide these options.
see:
#1609 (comment)

#1053

oldman4U · 2021-02-25T17:51:47Z

I can already see all the tickets coming in related to hidden features. 🎉

guruathwal · 2021-02-26T07:10:19Z

I think these are better to stay in the feature menu:
label_default_mode:Default Mode
label_fil_runout_inverting:Inverted Filament Runout Logic

May be necessary to put some common settings and non-common settings in different lists ?
for example
->0. Frequently-used settings
        ->1. Common settings
                ->2. File list mode
                ->2. filament sensor
->0. Not frequently-used settings
->0. System settings
The advantage of this is that users need not use SD to plug in the computer to modify the settings, and almost all the settings can be modified on the screen directly.
The disadvantage is that these label strings will take up a lot of memory flash

Currently, there are 93 parameters that are not displayed in settings menus and most of them have at least 2-3 sub-parameters. even if half of these are selected to be added in the settings menus total entries will be close to 200. Category wise list or as a single list, it will be a long list.
The core reason for the problem is the lack of proper documentation/guide for providing details of available feature and settings.

- Add Marlin mode settings menu in screen settings. - Add Brightness settings menu. in screen settings. - Remove some items from feature settings menu, which should only be configured through config file. - Replace the word 'Simulator' with 'Emulator'. - replace u8, u16, u32 with uint8_t, uint16_t, uint32_t - enable post-processor for displays with SSD1963 to reduce banding on some devices. - move frequently polled commands to top in parseACK.c

guruathwal added 18 commits January 24, 2021 20:10

remove unnecessary global variables

fb1b1f6

fix busy wait bug in load unload

6d12b58

Merge remote-tracking branch 'upstream/master' into dev

f0c631a

Merge remote-tracking branch 'upstream/master' into dev

dded776

Update Print.c

a5d3d7d

stringToDouble ignore tab character

060392c

Merge remote-tracking branch 'upstream/master' into dev

bedd622

Update Fan.c

7dfa91f

Update Fan.c

556f650

Merge remote-tracking branch 'upstream/master' into dev

129ca96

Update ScreenSettings.c

2f19978

Update pin_TFT24_V1_1.h

9620050

Update pin_MKS_TFT32_V1_4.h

037dcee

Update ScreenSettings.c

7d11545

Update pin_TFT24_V1_1.h Update pin_MKS_TFT32_V1_4.h

Merge branch 'dev' of https://github.com/guruathwal/BIGTREETECH-Touch…

785795d

…ScreenFirmware into dev

replace u8, u16, u32 with uint8_t, uint16_t, uint32_t

f01160e

Update Babystep.c

2c67c7b

fix typo

dde824f

fix case

6e0db2a

fix main board not booting if serial is disabled on booting in marlin…

cc30818

… mode: change logic

Update interfaceCmd.c

1e2aee5

guruathwal added 3 commits February 21, 2021 19:06

Update MarlinMode.c

fd7bace

Update Selectmode.c

6a12928

Update Selectmode.c

87c0442

radek8 suggested changes Feb 21, 2021

View reviewed changes

Update MachineParameters.c

cc75b9a

guruathwal added 3 commits February 23, 2021 10:40

enable post-processor for SSD1963

16ca121

enable post-processor for displays with SSD1963 to reduce banding on some devices.

move frequently polled commands to top in parseACK.c

690e42a

Update utf8_decode.c

da621b0

radek8 mentioned this pull request Feb 24, 2021

Update icons. #1638

Merged

sync language_hu.h

711437c

Merge branch 'dev' of https://github.com/guruathwal/BIGTREETECH-Touch…

5d038c4

…ScreenFirmware into dev

bigtreetech merged commit 20f724f into bigtreetech:master Feb 26, 2021

sarvenn mentioned this pull request Mar 4, 2021

[BUG] Marlin does not boot if TFT is in LCD Emulator Mode #1657

Closed

sarvenn mentioned this pull request Jun 9, 2021

[BUG] Home Offset Y value does not update properly #1982

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new settings categories and clean up #1633

Add new settings categories and clean up #1633

guruathwal commented Feb 18, 2021 •

edited

Loading

oldman4U commented Feb 18, 2021

guruathwal commented Feb 18, 2021

oldman4U commented Feb 18, 2021

AntoszHUN commented Feb 18, 2021

sarvenn commented Feb 18, 2021

Guilouz commented Feb 18, 2021 •

edited

Loading

oldman4U commented Feb 18, 2021

kisslorand commented Feb 18, 2021 •

edited

Loading

traffic-light commented Feb 18, 2021

traffic-light commented Feb 18, 2021 •

edited

Loading

radek8 commented Feb 21, 2021

radek8 commented Feb 21, 2021 •

edited

Loading

radek8 commented Feb 21, 2021 •

edited

Loading

guruathwal commented Feb 21, 2021

radek8 left a comment •

edited

Loading

digant73 commented Feb 22, 2021 •

edited

Loading

radek8 commented Feb 22, 2021 •

edited

Loading

digant73 commented Feb 22, 2021

radek8 commented Feb 25, 2021 •

edited

Loading

bigtreetech commented Feb 25, 2021

oldman4U commented Feb 25, 2021

radek8 commented Feb 25, 2021 •

edited

Loading

oldman4U commented Feb 25, 2021

guruathwal commented Feb 26, 2021

Add new settings categories and clean up #1633

Add new settings categories and clean up #1633

Conversation

guruathwal commented Feb 18, 2021 • edited Loading

oldman4U commented Feb 18, 2021

guruathwal commented Feb 18, 2021

oldman4U commented Feb 18, 2021

AntoszHUN commented Feb 18, 2021

sarvenn commented Feb 18, 2021

Guilouz commented Feb 18, 2021 • edited Loading

oldman4U commented Feb 18, 2021

kisslorand commented Feb 18, 2021 • edited Loading

traffic-light commented Feb 18, 2021

traffic-light commented Feb 18, 2021 • edited Loading

radek8 commented Feb 21, 2021

radek8 commented Feb 21, 2021 • edited Loading

radek8 commented Feb 21, 2021 • edited Loading

guruathwal commented Feb 21, 2021

radek8 left a comment • edited Loading

Choose a reason for hiding this comment

digant73 commented Feb 22, 2021 • edited Loading

radek8 commented Feb 22, 2021 • edited Loading

digant73 commented Feb 22, 2021

radek8 commented Feb 25, 2021 • edited Loading

bigtreetech commented Feb 25, 2021

oldman4U commented Feb 25, 2021

radek8 commented Feb 25, 2021 • edited Loading

oldman4U commented Feb 25, 2021

guruathwal commented Feb 26, 2021

guruathwal commented Feb 18, 2021 •

edited

Loading

Guilouz commented Feb 18, 2021 •

edited

Loading

kisslorand commented Feb 18, 2021 •

edited

Loading

traffic-light commented Feb 18, 2021 •

edited

Loading

radek8 commented Feb 21, 2021 •

edited

Loading

radek8 commented Feb 21, 2021 •

edited

Loading

radek8 left a comment •

edited

Loading

digant73 commented Feb 22, 2021 •

edited

Loading

radek8 commented Feb 22, 2021 •

edited

Loading

radek8 commented Feb 25, 2021 •

edited

Loading

radek8 commented Feb 25, 2021 •

edited

Loading