Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard deviation - BLTouch repeatability test #1484

Merged
merged 27 commits into from
Jan 12, 2021

Conversation

kisslorand
Copy link
Contributor

@kisslorand kisslorand commented Jan 5, 2021

Requirements

BTT TFT ot MKS TFT

Description

This PR adds the missing "Standard deviation" info on BLTouch repeatability test. It was done taking extra care not to increase RAM usage. Additional optimizations were made to reduce compiled size.

Benefits

It enhances the informations displayed when a BLTouch repeatability test is done.

Related Issues

Fixes #1102

RAM & Flash impact

RAM -> 0 bytes extra
Flash -> 368 bytes extra

Additional info

NO, the things introduced in this PR are NOT user selectable, there is NO adjustable thing in config.ini nor in parameters settings. There's NO additional popup. Nothing was removed, it's an extra.

@digant73
Copy link
Contributor

digant73 commented Jan 6, 2021

Please revert abl, mbl, mesheditor, pid, probeoffset. They used the most correct and safe buffer copy

@kisslorand
Copy link
Contributor Author

Please help me understand what's the problem as it is? (other that there are two typos I missed)

@kisslorand
Copy link
Contributor Author

9e5e449 - (theoretically) faster string concatenation and format, reduced compiled size
2a62a8d - safer string concatenation and format as per @digant73's advice, compiled size bigger by 204 bytes.

In my tests I couldn't find any difference in functionality between the two commits mentioned.

@ETE-Design
Copy link

Is this also for the M48 repeatability test, and could you mabye add an button to run the process then?

@kisslorand
Copy link
Contributor Author

kisslorand commented Jan 8, 2021

There is a button for this.
Menu -> Move -> Bed Level -> ABL -> BLTouch -> Repeat
...and it's exactly M48 what it does.

@ETE-Design
Copy link

@kisslorand Ahh haven't seen that, cause don't use an BLTouch but an Inductive Sensor so dosen't make sense I have to look there to do a M48 who work on all sensors... And the rest of the options inside BLTouch is just for BLTouch... Mabye that function should be moved to another place so people with other sensors know the M48 is possible...

@kisslorand
Copy link
Contributor Author

kisslorand commented Jan 8, 2021

Everyone can do it easily, just put M48 in your custom gCode list in Config.ini.
custom_label_8:Repeatibility test
custom_gcode_8:G28\nM48\n

@kisslorand
Copy link
Contributor Author

@bigtreetech

This PR is ready to be merged, no bugs found nor reported, no conflicts with master branch.
You can choose the flavor you like from these two from here: #1484 (comment)

@bigtreetech bigtreetech merged commit 69dfb26 into bigtreetech:master Jan 12, 2021
Uz45 added a commit to Uz45/BIGTREETECH-TouchScreenFirmware that referenced this pull request Jan 15, 2021
Auto detect Firmware Type bigtreetech#1507
Fix filenames to work on TFT24 to reset settings after firmware was updated bigtreetech#1499
Add Menu TouchMI bigtreetech#1496
Implemet Print from SD-Crd for RepRapFirmware bigtreetech#1495
Enhanced italian language bigtreetech#1490
Onboard SD print - Long filename; TFT aware of other printing host bigtreetech#1488
Standard deviation - BLTouch repeatability test bigtreetech#1484
Add Z Steppers Auto-Alignment (G34) bigtreetech#1483
Updated ReadMe bigtreetech#1475
jeffeb3 pushed a commit to V1EngineeringInc/BIGTREETECH-TouchScreenFirmware that referenced this pull request Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] (standard deviation on repeatability test )
5 participants