Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TO DO List #1830

Closed
6 of 8 tasks
bigtreetech opened this issue Apr 12, 2021 · 36 comments
Closed
6 of 8 tasks

TO DO List #1830

bigtreetech opened this issue Apr 12, 2021 · 36 comments
Labels
Abandoned enhancement New feature or request

Comments

@bigtreetech
Copy link
Owner

bigtreetech commented Apr 12, 2021

What we should do next

Bugfix

  • Klipper 12864 mode [FR] [ST7920_Simulator.c] Add a character generator in order to use klipper #290
    progress: The API Application of the upper layer is basically implemented in cleanup & fix st7920 simulator (add klipper support) #705 . In my test, the problem occurs in the SPI slave part of the bottom layer. The SPI data received from klipper will shift by one bit.
  • RGB Printing heating color not change marlin neopixel Color cycle. #1786
    progress: In fact, it is not a really bug, It's a known limitation. Marlin will activate the LED change only after receiving the "M190/M109" gcode, but this gcode will cause the communication interruption between the TFT and Marlin (because Marlin will not respond to other gcode before reaching the target temperature), so TFT will convert this gcode to "M140/M104" to avoid communication interruption, but Marlin will not be able to activate the LED change normally.

Improve

Development direction

@bigtreetech bigtreetech added the enhancement New feature or request label Apr 12, 2021
@bigtreetech bigtreetech pinned this issue Apr 12, 2021
@bigtreetech bigtreetech changed the title TO DO List [FR] TO DO List Apr 12, 2021
@oldman4U
Copy link
Contributor

I would add "Developers wanted" to the headline.

@digant73
Copy link
Contributor

digant73 commented Apr 13, 2021

I can implement the machine RGB settings custom color.
My idea is to to provide in the current RGB menu:

  1. a standard color select button. A list menu reporting standard colors will be used to select the color
  2. a custom color select button. A new menu to select the RGB components will be available to set color. The menu will be usable as general RGB color pickup. A proper callback to handle the selected color will be registered. E.g. a callback to set the printer LED color etc...
  3. a button to switch between standard/custom selected color
  4. a ON/OFF button to quickly switch on/off the printer LED

That will allow to reduce the number of icons. Some of the remaining icons will need to be rearranged (that is out of scope for me; not an artist at all)

@oldman4U
Copy link
Contributor

I would avoid new bmp's as much as possible and to use the Text below them to describe what it does. Most symbols are already hard to understand, at least this is my feeling.

@digant73
Copy link
Contributor

digant73 commented Apr 16, 2021

could it be OK the following menu to select a custom LED RGB color?
I will add also the W, intensity and index for NEO Pixel

IMG_20210415_231203

@oldman4U
Copy link
Contributor

Can you click on the value to get a keypad?
Can you see the resulting colour somewhere (approximately;-))?

@digant73
Copy link
Contributor

digant73 commented Apr 16, 2021

yes to both questions.
The range value for each component is 0-255 (matches the LED RGB color components range).
The TFT RGB color components are clearly a subset of the LED RGB color components. TFT uses RGB 565 format (so 5 bit for R and B and 6 for G). That means the RGB colors displayed by TFT cannot match the LED color. They wil be repeaded once they overlap 5 and 6 bits. I displayed the RGB on TFT just as TFT color pickup.

@sinole1987
Copy link

can you add mid print nozzle freezing to the to do list. Its a very big issue and never got fixed. last night I had another freez. It mostly happen on long prints.

@digant73
Copy link
Contributor

wasn't "Restructure icon/list/etc... menu API (and related touch API) provides a more general API interface" recently implemented by Gurmeet with his last merged PR?

@guruathwal
Copy link
Contributor

wasn't "Restructure icon/list/etc... menu API (and related touch API) provides a more general API interface" recently implemented by Gurmeet with his last merged PR?

not completely, I am still working on it.

@bttguy
Copy link

bttguy commented May 29, 2021

@bigtreetech Can I ask you to include some RRF related improvements listed in #1791? I can help you with testing :)

@bigtreetech
Copy link
Owner Author

@bigtreetech Can I ask you to include some RRF related improvements listed in #1791? I can help you with testing :)

Hello, It is being implemented in #1962

@stale
Copy link

stale bot commented Jul 31, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Abandoned label Jul 31, 2021
@guruathwal
Copy link
Contributor

Dear Stale bot, please don't mark this one as stale. 😂

@stale stale bot removed the Abandoned label Jul 31, 2021
@Minims
Copy link

Minims commented Sep 9, 2021

Hello, is it possible to add a moonraker api compatibilty layer to use the TOuchscreen mode on klipper, like paneldue or the ender3v2 screen ? Thx!

This version of Klipper already have serial PIN configure. maybe it need some few thing to make but touchscreen working :
Desuuuu/klipper#74

@stale
Copy link

stale bot commented Nov 8, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Abandoned label Nov 8, 2021
@sarvenn
Copy link

sarvenn commented Nov 8, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@oldman4U . Topic is about to be closed.

@stale stale bot removed the Abandoned label Nov 8, 2021
@oldman4U
Copy link
Contributor

oldman4U commented Nov 8, 2021

Hi sarvenn.

I am not the owner but such tickets are automatically reopened.

@sarvenn
Copy link

sarvenn commented Nov 9, 2021

Hi sarvenn.

I am not the owner but such tickets are automatically reopened.

Oh, sorry. :) I missed that. You are the first one came up in my mind for this platform 😃

@bigtreetech for your information.

@yannick-alch
Copy link

yannick-alch commented Dec 14, 2021

can you add mid print nozzle freezing to the to do list. Its a very big issue and never got fixed. last night I had another freez. It mostly happen on long prints.

@sinole1987
I have the same problem on long print. The nozzle freeze into the piece, and motor are still lock and temperature are kept. Maybe the screen didn't received the "ok" response from the motherboard ?
Is there a way to resent the "ok" message after an amount of time ?

@digant73
Copy link
Contributor

@bigtreetech Event LED feature could be now marked as done. Also PR #1209 could be removed. All the features on that PR have been implemented.

@sinole1987
Copy link

sinole1987 commented Dec 27, 2021

can you add mid print nozzle freezing to the to do list. Its a very big issue and never got fixed. last night I had another freez. It mostly happen on long prints.

@sinole1987 I have the same problem on long print. The nozzle freeze into the piece, and motor are still lock and temperature are kept. Maybe the screen didn't received the "ok" response from the motherboard ? Is there a way to resent the "ok" message after an amount of time ?

you need to make a sleeved cable out of a usb cable and use the braded jacket for ground pin and 24 awg red cable for power. after that you need to wrap it in ferrite beads on both ends. It will get much better. there is a whole post about it.

@stale
Copy link

stale bot commented Feb 26, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Abandoned label Feb 26, 2022
@digant73
Copy link
Contributor

please stay with us

@stale stale bot removed the Abandoned label Feb 28, 2022
@stale
Copy link

stale bot commented May 25, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Abandoned label May 25, 2022
@sinole1987
Copy link

Not the todo list :)

@stale stale bot removed the Abandoned label May 25, 2022
@thisiskeithb
Copy link
Contributor

@bigtreetech You need to add the TODO label to this issue so stalebot doesn't close this.

# Issues or Pull Requests with these labels will never be considered stale. Set to `[]` to disable
exemptLabels:
- pinned
- security
- TODO
- "[Status] Maybe Later"

@Tannoo
Copy link

Tannoo commented Jun 23, 2022

You mean "TO DO"? Or the title needs to be changed to "TODO".

@stale
Copy link

stale bot commented Sep 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Abandoned label Sep 16, 2022
@oldman4U
Copy link
Contributor

ToDo ;-)

@xPew
Copy link
Contributor

xPew commented Sep 22, 2022

Just some more time dear bot!

@stale stale bot removed the Abandoned label Sep 22, 2022
@oldman4U
Copy link
Contributor

MAGIC!!!😁

@guruathwal
Copy link
Contributor

Mr Stale is the only person regularly maintaining this repo 🤣

@stale
Copy link

stale bot commented Nov 22, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Abandoned label Nov 22, 2022
@oldman4U
Copy link
Contributor

And me. 😁

@stale stale bot removed the Abandoned label Nov 24, 2022
@stale
Copy link

stale bot commented Feb 5, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Abandoned label Feb 5, 2023
@stale stale bot closed this as completed Feb 19, 2023
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Abandoned enhancement New feature or request
Projects
None yet
Development

No branches or pull requests