Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

marlin neopixel Color cycle. #1786

Closed
sinole1987 opened this issue Apr 1, 2021 · 16 comments · Fixed by #2286
Closed

marlin neopixel Color cycle. #1786

sinole1987 opened this issue Apr 1, 2021 · 16 comments · Fixed by #2286
Labels
enhancement New feature or request TODO

Comments

@sinole1987
Copy link

I connected neopixels to SKR 1.4 board, but in TFT mode the set color cycle that marlin performs during heating doesn't happen. it would be cool to have that.

thank you

@sinole1987 sinole1987 added the enhancement New feature or request label Apr 1, 2021
@gordo3di
Copy link

gordo3di commented Apr 1, 2021

Weird. I have the same board and mine does the startup color cycle with no issues since the skr v1.4 and marlin are independent of the LCD screen. Marlin 2.0.6.2 I believe. I would guess it's something in marlin not the touch screen.

Can you change the color via the LED menu?

@oldman4U
Copy link
Contributor

oldman4U commented Apr 1, 2021

You both print from?

@oldman4U
Copy link
Contributor

oldman4U commented Apr 1, 2021

Please see #1620 and also the PR from traffic-light.

@sinole1987

Maybe you can collect all your neopixel related tickets into one.

@sinole1987
Copy link
Author

sinole1987 commented Apr 1, 2021

Weird. I have the same board and mine does the startup color cycle with no issues since the skr v1.4 and marlin are independent of the LCD screen. Marlin 2.0.6.2 I believe. I would guess it's something in marlin not the touch screen.

Can you change the color via the LED menu?

it works in marlin mode, although we know from load unload issue, that doesn't mean anything. it could be very well a marlin issue. but it just works in marlin mode. I use latest version of marlin. I think 2.0.7

@sinole1987
Copy link
Author

Please see #1620 and also the PR from traffic-light.

@sinole1987

Maybe you can collect all your neopixel related tickets into one.

sure, didn't wana mix two tings up.

@oldman4U
Copy link
Contributor

oldman4U commented Apr 1, 2021

2 Q open.

Can you change the color using the menu?

You print from mainboard or TFT?

@sinole1987
Copy link
Author

ye i can manually change the color from machine settings in TFT. Btw I think the light setting should be a little more accessible. Automatic color cycling doesn't happen during a TFT print. it works in marlin mode. I think marlin performs an Internal Gcode during heat up cycle that does not happen when TFT is hosting print. looks like its more of a marlin issue. The reason I labeled this issue as feature request, was because I though we can replicate the Gcode in TFT like M600.

@oldman4U
Copy link
Contributor

oldman4U commented Apr 2, 2021

As far as I know this is exactly what traffic-light want to do.

@gordo3di
Copy link

gordo3di commented Apr 5, 2021

Sorry. I thought you wanted the "startup color" cycle that the nepoixels do not the rgb status colors. Yeah as far as I know it's still not implemented. If you want the status colors on pause, cancel and print complete you can add them to your gcode via the slicer (or on the tft screen config.ini) so at least you can have that functionality.

https://marlinfw.org/docs/gcode/M150.html

@sinole1987
Copy link
Author

Sorry. I thought you wanted the "startup color" cycle that the nepoixels do not the rgb status colors. Yeah as far as I know it's still not implemented. If you want the status colors on pause, cancel and print complete you can add them to your gcode via the slicer (or on the tft screen config.ini) so at least you can have that functionality.

https://marlinfw.org/docs/gcode/M150.html

that is a great Idea, it doesn't have to be programed into the TFT, but I think it will be a very loaded Gcode. I will try to write it , real challenge is to set colors for each pixel to and give them temperature condition.

@gordo3di
Copy link

gordo3di commented Apr 7, 2021

Sorry. I thought you wanted the "startup color" cycle that the nepoixels do not the rgb status colors. Yeah as far as I know it's still not implemented. If you want the status colors on pause, cancel and print complete you can add them to your gcode via the slicer (or on the tft screen config.ini) so at least you can have that functionality.
https://marlinfw.org/docs/gcode/M150.html

that is a great Idea, it doesn't have to be programed into the TFT, but I think it will be a very loaded Gcode. I will try to write it , real challenge is to set colors for each pixel to and give them temperature condition.

For anyone interested, I actually had a very nice neopixel progress bar working in marlin a long time ago. It would go from red to green as it heated and it would also fill up during a print so you could see progress from very far away. It was super useful since we have a big print farm and it was nice to easily see the progress per printer.

The problem is the 8 bit arduino couldn't handle it and it led to tons of layer shifting issues (it took me weeks and a lot of lost filament to determine the issue). From that point I abandoned it but if anyone wants to make sense of the code its here. My code changes start around halfway through the thread. I'm not sure how hard this would be to implement in the touchscreen or on the SKR.

MarlinFirmware/Marlin#8915

@bigtreetech bigtreetech mentioned this issue Apr 12, 2021
8 tasks
@oldman4U
Copy link
Contributor

From BTTs to do list.

In fact, it is not a really bug, It's a known limitation. Marlin will activate the LED change only after receiving the "M190/M109" gcode, but this gcode will cause the communication interruption between the TFT and Marlin (because Marlin will not respond to other gcode before reaching the target temperature), so TFT will convert this gcode to "M140/M104" to avoid communication interruption, but Marlin will not be able to activate the LED change normally

@Rincewind08
Copy link

Emergency Parser?

@Tannoo
Copy link

Tannoo commented Jun 7, 2021

#1974

@Marcos2BR
Copy link

Marcos2BR commented Dec 17, 2021

thanks digant73 , the file in "Copy to SD Card - BTT/ BIGTREE_TFT35_V3.0.27.x.bin" (december 16/21 ) work fine the led event (neopixel Color cycle) in my hypercube with skr1.4 +TFT35-V3.0 (esp01S coupled on tft )
ps: i use Bigtree3DPlugin Suit + SD card, all work fine

https://github.com/digant73/BIGTREETECH-TouchScreenFirmware/tree/bugfix/Copy%20to%20SD%20Card%20-%20BTT

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request TODO
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants