Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Make the LED/Lights menu in TFT mode more feature complete #1687

Closed
lightmaster opened this issue Mar 7, 2021 · 9 comments · Fixed by #1853
Closed

[FR] Make the LED/Lights menu in TFT mode more feature complete #1687

lightmaster opened this issue Mar 7, 2021 · 9 comments · Fixed by #1853
Labels
enhancement New feature or request

Comments

@lightmaster
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Can not set a Custom Light using the TFT Touch Screen mode without resorting to using terminal and M150 command. If the average user that doesn't know much about gcode commands wants to change the LEDs to something besides Red, Green, Blue, and White, then they have to switch to Marlin mode and can then have full access to Marlin's much more fleshed out Lights menu. Furthermore, I propose expanding the preset colors to also include the other primary and secondary colors used by Marlin (ROY G BIV colors).

Describe the solution you'd like
Kinda feel that's pretty self explanatory from above, but I'd like the TFT Touch Screen LED menu to be more fleshed out and have the options that Marlin Mode has.

Describe alternatives you've considered
Encourage anyone wanting to play around with the LED colors to use Marlin Mode, or continue to require them to understand GCode and RGB color codes

Additional context
Add any other context or screenshots about the feature request here.

@lightmaster lightmaster added the enhancement New feature or request label Mar 7, 2021
@oldman4U
Copy link
Contributor

oldman4U commented Mar 7, 2021

How many of this ecustom colours should be possible and how would such custom colours look like on screen, custom buttons?

I can see this a lot of work for little benefit and there are custom gCode commands which could be used for that.

my 2 cents

@bigtreetech
Copy link
Owner

Maybe it can add a custom button in the LED Color menu. After clicking in, it can directly set the value of each R/G/B by the keyboard?
It's a good idea, and It can reuse Custom icon without adding new icons avoid taking up more flash memory.
We are going to release a new version of firmware in the near future. The main task at present is to test and fix bugs. If you are willing to submit PR to add this function , I will be verry happy to test it.

@lightmaster
Copy link
Contributor Author

Going back to the LED menu, I didn't realize how few space there is without shrinking the icons and potentially causing issues with smaller screens and bigger fingers....

So what about a Custom icon like @bigtreetech described, and potentially a second icon called "Other" to fill the final open spot and it directs to a menu that has a list various other colors. This menu would look like the Custom GCode menu.

@DaStivi
Copy link

DaStivi commented Mar 8, 2021

i think it would be ah nice idea... I'd might have another one, do add some sort of option to auto enable lightning from the features menu? like to turn on white light from the start without having to go into the menu's or use the gcode

@lightmaster
Copy link
Contributor Author

i think it would be ah nice idea... I'd might have another one, do add some sort of option to auto enable lightning from the features menu? like to turn on white light from the start without having to go into the menu's or use the gcode

You mean when the printer turns on? My NeoPixel turns on at boot. If you have an RGB strip and it doesn't, that's probably a better thing to bring up in the Marlin Github. If you have NeoPixel, check your config: https://github.com/MarlinFirmware/Marlin/blob/b26516b3ac7cd7d15a751af4b299a38ac8ac7a57/Marlin/Configuration_adv.h#L1107

@oldman4U
Copy link
Contributor

Hi. What is the status of the feature request?

@bigtreetech
Copy link
Owner

Hi. What is the status of the feature request?

Waiting for implementation

@digant73
Copy link
Contributor

Now it is implemented

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
5 participants