Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): make Select scrollable with popper positioning #942

Merged
merged 1 commit into from
May 23, 2024

Conversation

jorgemoya
Copy link
Contributor

What/Why?

This fixes a side effect of #757, by adding a fixed heigh the Select as popper works as it should, allowing scrolling and properly rendering under the trigger.

Screenshot 2024-05-22 at 1 34 51 PM

Testing

Locally.

@jorgemoya jorgemoya requested a review from a team as a code owner May 22, 2024 18:41
Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 6:41pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) May 22, 2024 6:41pm
catalyst-au ⬜️ Ignored (Inspect) May 22, 2024 6:41pm
catalyst-test-store ⬜️ Ignored (Inspect) May 22, 2024 6:41pm
catalyst-uk ⬜️ Ignored (Inspect) May 22, 2024 6:41pm

Copy link

changeset-bot bot commented May 22, 2024

🦋 Changeset detected

Latest commit: ebc467e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-iy3q5plb7-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 100
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 90

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 96
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 92

@bc-alexsaiannyi
Copy link
Contributor

Hey @jorgemoya. It looks good but just curious if speed of scrolling is something that can be adjust? Doesn't it look too fast?

Screen.Recording.2024-05-23.at.14.11.26.mov

@jorgemoya
Copy link
Contributor Author

Hey @jorgemoya. It looks good but just curious if speed of scrolling is something that can be adjust? Doesn't it look too fast?

Screen.Recording.2024-05-23.at.14.11.26.mov

Good callout. I looked and it appears it's not configurable, so this will need to make do for now.

@jorgemoya jorgemoya added this pull request to the merge queue May 23, 2024
Merged via the queue into main with commit c7c65e0 May 23, 2024
11 checks passed
@jorgemoya jorgemoya deleted the fix-select-popover branch May 23, 2024 17:40
This was referenced May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants