fix: select component wouldn't scroll with long list #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0d8899a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
chanceaclark
force-pushed
the
fix/select-scroll
branch
from
f87c30e
to
75d8e54
Compare
deini
reviewed
Apr 12, 2024
| className={cn( | ||
| 'w-full', | ||
| position === 'popper' && | ||
| 'h-[var(--radix-select-trigger-height)] w-full min-w-[var(--radix-select-trigger-width)]', |
chanceaclark
force-pushed
the
fix/select-scroll
branch
from
75d8e54
to
3ef44ff
Compare
deini
approved these changes
Apr 12, 2024
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-crg1rohe3-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
jorgemoya
approved these changes
Apr 12, 2024
chanceaclark
force-pushed
the
fix/select-scroll
branch
from
3ef44ff
to
0d8899a
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
Updates the behavior of the select component in order to scroll for longer lists.
Testing
Screen.Recording.2024-04-12.at.11.37.11.mov