-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH Issue #66 - Scrollable Panels with Sticky Navigation Tree Items #67
GH Issue #66 - Scrollable Panels with Sticky Navigation Tree Items #67
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @thatisrich ! It's looking good. I have left some inline comments, overall this functions well but I did notice an issue if the preview size increases beyond a certain size when you're in the larger breakpoint.
Recreation steps:
- Select
site > padding
- Increase to
400px
- Notice the preview disappears and does not stack like it would on smaller screens
Demo:
Screen.Capture.on.2024-06-25.at.13-17-07.mp4
I don't think we should allow any styles to affect the overall size of the preview, this may be fixable by adding a set width
to the themer-preview-container
Thanks @g-elwell! To tackle the preview container exceeding the page when certain values are adjusted, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your efforts on this @thatisrich ! It's working great in my testing
Description
Completes GH Issue 66 - Due to the potential length of the element navigation tree, the element styles panel, and the visual preview panel,
overflow-y: scroll
has been added to the containers with the aim to add visual clarity for the authoring experience. To help with this, open elements within the navigation tree are 'attached' to the container while scroll to show where in the element tree the current scroll position is.Change Log
base.scss
- Added some styling to allow top level elements to scroll and also giving a height to.themer-body
nav-list.scss
- Added some styling to allow container scrolling and sticky items within the element treethemerPreview.scss
- Added some styling to allow container scrolling when requiredSteps to test
On a wide screen:
On a thinner screen:
Screenshots/Videos
A video showing the wide screen interactions can be found here
Checklist: