Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change visual preview to code view #62

Closed
jonnywatersbb opened this issue Jun 5, 2024 · 4 comments · Fixed by #68
Closed

Change visual preview to code view #62

jonnywatersbb opened this issue Jun 5, 2024 · 4 comments · Fixed by #68
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jonnywatersbb
Copy link
Member

jonnywatersbb commented Jun 5, 2024

What problem does this address?

Removing visual preview as described in (#61)

What is your proposed solution?

Replace with a live text view of the theme.json file, allowing users to instantly see the change in the code effected by altering a setting in the themer UI

Acceptance criteria

  • Output current theme.json file in place of the visual editor
  • Output theme.json within pre/code element
  • Ensure theme.json has the correct indentation
  • Use monospace font for legibility
  • Instant sync of the code view when a setting is changed within the UI
@g-elwell
Copy link
Member

thanks @chrishall0 and @squarewave17 for picking this up in #68 🙌

just a heads up - whilst we encourage reviews from everyone, code shouldn't be merged until it's been approved by someone from the lead engineering team or a named codeowner on a repo.

on this one, I've just tested the PR and it looks good, but I do have some feedback:

@chrishall0
Copy link
Contributor

thanks @chrishall0 and @squarewave17 for picking this up in #68 🙌

just a heads up - whilst we encourage reviews from everyone, code shouldn't be merged until it's been approved by someone from the lead engineering team or a named codeowner on a repo.

on this one, I've just tested the PR and it looks good, but I do have some feedback:

thanks @g-elwell, addressed those here

@squarewave17
Copy link
Contributor

thanks @chrishall0 and @squarewave17 for picking this up in #68 🙌

just a heads up - whilst we encourage reviews from everyone, code shouldn't be merged until it's been approved by someone from the lead engineering team or a named codeowner on a repo.

on this one, I've just tested the PR and it looks good, but I do have some feedback:

My apologies @g-elwell 🙏🏻

@g-elwell
Copy link
Member

g-elwell commented Jul 2, 2024

Resolved by #68 and #70 - thanks all!

@g-elwell g-elwell closed this as completed Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants