[Merged by Bors] - do not impl Component for Task #4113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
added
A-Tasks
|
You're right, I did link the wrong PR in #4052 (review); the link should have been #2975. |
|
Oh I missed that was part of that PR! |
|
This is better as a standalone PR as it seems #2975 may take some time before it could be merged |
alice-i-cecile
approved these changes
Mar 5, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
hymm
approved these changes
Mar 5, 2022
MrGVSV
approved these changes
Mar 5, 2022
pubrrr
reviewed
Mar 6, 2022
| @@ -41,6 +41,9 @@ fn add_assets( | |||
| commands.insert_resource(BoxMaterialHandle(box_material_handle)); | |||
| } | |||
|
|
|||
| #[derive(Component)] | |||
| struct ComputeTransform(Task<Transform>); | |||
There was a problem hiding this comment.
FYI, I also did this is #4102.
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 22, 2022
# Objective - `Task` are `Component`. - They should not. ## Solution - Remove the impl, and update the example to show a wrapper. #4052 for reference
bors
bot
changed the title
|
Should this be considered a breaking change? |
bjorn3
added
the
C-Breaking-Change
exjam
pushed a commit
to exjam/bevy
that referenced
this pull request
May 22, 2022
# Objective - `Task` are `Component`. - They should not. ## Solution - Remove the impl, and update the example to show a wrapper. bevyengine#4052 for reference
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - `Task` are `Component`. - They should not. ## Solution - Remove the impl, and update the example to show a wrapper. bevyengine#4052 for reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
TaskareComponent.Solution
#4052 for reference