Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Component for WASM FakeTask #4052

Closed
wants to merge 3 commits into from
Closed

Implement Component for WASM FakeTask #4052

wants to merge 3 commits into from

Conversation

aevyrie
Copy link
Member

@aevyrie aevyrie commented Feb 27, 2022 •
edited
Loading

Objective

Solution

  • Like Task, implement Component for FakeTask on the wasm32 target.

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Feb 27, 2022
DJMcNab
DJMcNab suggested changes Feb 27, 2022
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bonk

That is, we shouldn't be implementing Component for Task at all.

#2982 already would remove the other wrong impl, and that part of the pr is afaik entirely non-controversial.

@mockersf
Copy link
Member

I agree, neither Task or FakeTask should be component, and the example should use a wrapper type 👍

@mockersf mockersf added A-ECS Entities, components, systems, and events C-Usability A simple quality-of-life change that makes Bevy easier to use and removed S-Needs-Triage This issue needs to be labelled labels Feb 27, 2022
@alice-i-cecile
Copy link
Member

Closing this out, following the direction taken in #2982.

@mockersf mockersf mentioned this pull request Mar 5, 2022
Closed
bors bot pushed a commit that referenced this pull request Apr 22, 2022
@mockersf
do not impl Component for Task (#4113)
18c6a7b 
# Objective

- `Task` are `Component`.
- They should not.

## Solution

- Remove the impl, and update the example to show a wrapper.

#4052 for reference
exjam pushed a commit to exjam/bevy that referenced this pull request May 22, 2022
@mockersf @exjam
do not impl Component for Task (bevyengine#4113)
b5ac167 
# Objective

- `Task` are `Component`.
- They should not.

## Solution

- Remove the impl, and update the example to show a wrapper.

bevyengine#4052 for reference
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@mockersf @ItsDoot
do not impl Component for Task (bevyengine#4113)
e3cc2ee 
# Objective

- `Task` are `Component`.
- They should not.

## Solution

- Remove the impl, and update the example to show a wrapper.

bevyengine#4052 for reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DJMcNab DJMcNab DJMcNab requested changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Usability A simple quality-of-life change that makes Bevy easier to use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aevyrie @mockersf @alice-i-cecile @DJMcNab