Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Sub app label changes #2717

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - Sub app label changes #2717

wants to merge 7 commits into from

Conversation

cart
Copy link
Member

@cart cart commented Aug 24, 2021

Makes some tweaks to the SubApp labeling introduced in #2695:

  • Ergonomics improvements
  • Removes unnecessary allocation when retrieving subapp label
  • Removes the newly added "app macros" crate in favor of bevy_derive
  • renamed RenderSubApp to RenderApp

@zicklag (for reference)

@cart cart added the A-Rendering Drawing game state to the screen label Aug 24, 2021
@cart cart mentioned this pull request Aug 24, 2021
Closed
64 tasks
alice-i-cecile
alice-i-cecile approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my error reporting nit, looks good to me.

zicklag
zicklag approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@zicklag zicklag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Aug 24, 2021
@cart
Copy link
Member Author

cart commented Aug 24, 2021

bors r+

bors bot pushed a commit that referenced this pull request Aug 24, 2021
@cart
Sub app label changes (#2717)
9898469 
Makes some tweaks to the SubApp labeling introduced in #2695:

* Ergonomics improvements
* Removes unnecessary allocation when retrieving subapp label
* Removes the newly added "app macros" crate in favor of bevy_derive
* renamed RenderSubApp to RenderApp

@zicklag (for reference)
@bors
Copy link
Contributor

bors bot commented Aug 24, 2021

Pull request successfully merged into pipelined-rendering.

Build succeeded:

@bors bors bot changed the title Sub app label changes [Merged by Bors] - Sub app label changes Aug 24, 2021
@bors bors bot closed this Aug 24, 2021
@cart cart deleted the sub-app-label-changes branch October 31, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@zicklag zicklag zicklag approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cart @alice-i-cecile @zicklag