[Merged by Bors] - Implement Sub-App Labels #2695
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinerSebas
reviewed
Aug 20, 2021
zicklag
force-pushed
the
sub-app-labels
branch
2 times, most recently
from
d86a5b4
to
bc75882
Compare
zicklag
force-pushed
the
sub-app-labels
branch
2 times, most recently
from
ad5dad1
to
cf6b976
Compare
|
The new crate must also be added to the |
zicklag
force-pushed
the
sub-app-labels
branch
4 times, most recently
from
80c5c07
to
a93e204
Compare
Move the label implementation and derive code to bevy_utils and bevy_macro_utils crates to make it easier to reuse in other crates.
This replaces the temporary strategy of using indexes to access sub-apps.
64 tasks
|
I have a number of small tweaks that I'd normally just push to your branch, but it looks like you've disabled that permission. I'll just merge this as-is and follow up with another pr. |
|
(in the interest of time) |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 24, 2021
This is a rather simple but wide change, and it involves adding a new `bevy_app_macros` crate. Let me know if there is a better way to do any of this! --- # Objective - Allow adding and accessing sub-apps by using a label instead of an index ## Solution - Migrate the bevy label implementation and derive code to the `bevy_utils` and `bevy_macro_utils` crates and then add a new `SubAppLabel` trait to the `bevy_app` crate that is used when adding or getting a sub-app from an app.
|
Pull request successfully merged into pipelined-rendering. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rather simple but wide change, and it involves adding a new
bevy_app_macroscrate. Let me know if there is a better way to do any of this!Objective
Solution
bevy_utilsandbevy_macro_utilscrates and then add a newSubAppLabeltrait to thebevy_appcrate that is used when adding or getting a sub-app from an app.