Use NETCoreSdkVersion to determine which CSharpier tool version to use during builds #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@belav It won't let me assign this so pinging you instead. I tested by pinning repositories SDK version using global.json and deleting SDKs off of my machine then reinstalling. The end goal is the dotnet tool chosen should be the latest version the SDK supports. |
This was
linked to
issues
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issues:
#1027
#1022
#1019
Instead of using the current TargetFramework that is being built as part of the MSBuild process we use the SDK version that the MSBuild process is using to determine which version of the CSharpier dotnet tool we should use.
The goal is to allow those who only keep one version of an SDK and runtime installed on their machine the ability to use CSharpier in a more reliable manner.