Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logic for default target framework version for msbuild #1019

Closed
belav opened this issue Nov 16, 2023 · 0 comments · Fixed by #1034
Closed

Improve logic for default target framework version for msbuild #1019

belav opened this issue Nov 16, 2023 · 0 comments · Fixed by #1034

Comments

@belav
Copy link
Owner

belav commented Nov 16, 2023

The logic in CSharpier.MsBuild.targets will need to be updated every time a new .NET version comes up.

It should be possible to make use of something like this.

$([MSBuild]::VersionGreaterThanOrEquals($(_TargetFrameworkVersionWithoutV), '6.0'))

It will have to take into account the ability to override via CSharpier_FrameworkVersion

It is also not clear why this was required when adding net8 - CSharpier_FrameworkVersion=$(CSharpier_FrameworkVersion). Figure out if there is a better way to deal with this all. Right now a lot of it feels like a kludge.

If possible get some more test scenarios. Right now the only scenario uses net8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant