Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve symbolic links from external workspace to workspace root #5228

Merged
merged 4 commits into from
Sep 22, 2023
Merged

Resolve symbolic links from external workspace to workspace root #5228

merged 4 commits into from
Sep 22, 2023

Commits on Sep 22, 2023

  1. Follow symbolic links from external workspace to project 

    If some header search path to external workspace
actually points to workspace files then resolve
it to workspace path so code navigation is performed
to project files.
    @ujohnny
    ujohnny committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    890a8fb View commit details
    Browse the repository at this point in the history

  2. Follow symbolic links for external workspace sources 

    If source artifact points to project workspace then
resolve it to project location so project files should
be marked as synced in project view.
    @ujohnny
    ujohnny committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    46bfa96 View commit details
    Browse the repository at this point in the history

  3. Add in-project external workspaces to resolve configurations 

    If external workspace for some reason is located inside the
project (ie as a git submodule and added as local_repository)
then add it to resolve configurations and include in project
indexing to provide proper code insight. This will allow to
jump to definitions of thirdparty code or find usages etc.
    @ujohnny
    ujohnny committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    97e2b87 View commit details
    Browse the repository at this point in the history

  4. Sync only allowed external workspace target from project 

    Require external target directory within project to be listed
in directories section of project view file. Also introduces
registry key "bazel.cpp.sync.external.targets.from.directories"
which can be used to disable mentioned external targets sync.
    @ujohnny
    ujohnny committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    8946c22 View commit details
    Browse the repository at this point in the history