Resolve symbolic links from external workspace to workspace root #5228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
product: Android Studio
tpasternak
approved these changes
Sep 22, 2023
If some header search path to external workspace actually points to workspace files then resolve it to workspace path so code navigation is performed to project files.
If source artifact points to project workspace then resolve it to project location so project files should be marked as synced in project view.
If external workspace for some reason is located inside the project (ie as a git submodule and added as local_repository) then add it to resolve configurations and include in project indexing to provide proper code insight. This will allow to jump to definitions of thirdparty code or find usages etc.
Require external target directory within project to be listed in directories section of project view file. Also introduces registry key "bazel.cpp.sync.external.targets.from.directories" which can be used to disable mentioned external targets sync.
ujohnny
force-pushed
the
enovozhilov/external-workspace-to-project
branch
from
c54a34b
to
8946c22
Compare
tpasternak
approved these changes
Sep 22, 2023
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number: #4774
Description of this change
This PR addresses 2 issues both related to symbolic links from external workspace to workspace root.
When some catalog from project is added via
local_repositorythen bazel sets up symbolic link fromexternal workspace location to project, but CLion, for example, considers symbolic links as files itself,
thus the real files beneath links are either not marked as synced or not used for header location
resolution. This PR introduces the ability to resolve real files by following symbolic links what fixes #4774.