Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2201.7.x] Fix exiting bal test when a program has listeners and running workers/async functions #41314

Merged
merged 30 commits into from
Sep 6, 2023

Conversation

Nadeeshan96
Copy link
Contributor

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues.

$title
Fixes #41213
Fixes #40934

Duplicate PR #41210

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@Nadeeshan96 Nadeeshan96 added the Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime label Aug 29, 2023
@Nadeeshan96 Nadeeshan96 added this to the 2201.7.3 milestone Aug 31, 2023
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch coverage: 73.31% and project coverage change: -0.02% ⚠️

Comparison is base (e846469) 76.47% compared to head (42a404e) 76.46%.
Report is 19 commits behind head on 2201.7.x.

Additional details and impacted files
@@              Coverage Diff               @@
##             2201.7.x   #41314      +/-   ##
==============================================
- Coverage       76.47%   76.46%   -0.02%     
- Complexity      55258    55325      +67     
==============================================
  Files            3377     3389      +12     
  Lines          208086   208494     +408     
  Branches        26940    26968      +28     
==============================================
+ Hits           159141   159426     +285     
- Misses          40190    40297     +107     
- Partials         8755     8771      +16     
Files Changed Coverage Δ
...llerinalang/compiler/bir/codegen/JvmConstants.java 100.00% <ø> (ø)
...lerinalang/compiler/bir/codegen/JvmPackageGen.java 89.33% <ø> (-0.26%) ⬇️
...rinalang/compiler/bir/emit/InstructionEmitter.java 37.93% <0.00%> (-0.88%) ⬇️
...a/io/ballerina/xmltorecordconverter/Constants.java 0.00% <0.00%> (ø)
...verter/XMLToRecordConverterClientCapabilities.java 0.00% <0.00%> (ø)
...er/XMLToRecordConverterClientCapabilitySetter.java 0.00% <0.00%> (ø)
...verter/XMLToRecordConverterServerCapabilities.java 0.00% <0.00%> (ø)
...er/XMLToRecordConverterServerCapabilitySetter.java 0.00% <0.00%> (ø)
...orecordconverter/diagnostic/DiagnosticMessage.java 0.00% <0.00%> (ø)
...ter/diagnostic/XMLToRecordConverterDiagnostic.java 0.00% <0.00%> (ø)
... and 14 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gabilang gabilang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nadeeshan96 Nadeeshan96 merged commit 24011b1 into ballerina-platform:2201.7.x Sep 6, 2023
5 of 7 checks passed
@Nadeeshan96 Nadeeshan96 deleted the 7x-fix-test-exec branch October 26, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants