-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2201.7.x] Fix exiting bal test
when a program has listeners and running workers/async functions
#41314
Merged
Nadeeshan96
merged 30 commits into
ballerina-platform:2201.7.x
from
Nadeeshan96:7x-fix-test-exec
Sep 6, 2023
Merged
[2201.7.x] Fix exiting bal test
when a program has listeners and running workers/async functions
#41314
Nadeeshan96
merged 30 commits into
ballerina-platform:2201.7.x
from
Nadeeshan96:7x-fix-test-exec
Sep 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nadeeshan96
added
the
Team/jBallerina
All the issues related to BIR, JVM backend code generation and runtime
label
Aug 29, 2023
13 tasks
Nadeeshan96
requested review from
hevayo,
sameerajayasoma and
hasithaa
as code owners
August 31, 2023 09:10
gabilang
reviewed
Sep 1, 2023
...-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/methodgen/InitMethodGen.java
Outdated
Show resolved
Hide resolved
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## 2201.7.x #41314 +/- ##
==============================================
- Coverage 76.47% 76.46% -0.02%
- Complexity 55258 55325 +67
==============================================
Files 3377 3389 +12
Lines 208086 208494 +408
Branches 26940 26968 +28
==============================================
+ Hits 159141 159426 +285
- Misses 40190 40297 +107
- Partials 8755 8771 +16
☔ View full report in Codecov by Sentry. |
gabilang
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$title
Fixes #41213
Fixes #40934
Duplicate PR #41210
Approach
Samples
Remarks
Check List