Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2201.7.x] Handle init and start failures during test execution #41006

Closed

Conversation

gabilang
Copy link
Contributor

@gabilang gabilang commented Jul 14, 2023

Purpose

Fixing missing init and start failure handling

Fixes #40934

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@gabilang gabilang added the Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime label Jul 14, 2023
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.24% 🎉

Comparison is base (290c8d5) 76.44% compared to head (8aa18c7) 76.68%.
Report is 56 commits behind head on 2201.7.x.

Additional details and impacted files
@@              Coverage Diff               @@
##             2201.7.x   #41006      +/-   ##
==============================================
+ Coverage       76.44%   76.68%   +0.24%     
- Complexity      55209    55583     +374     
==============================================
  Files            3377     3377              
  Lines          208001   211134    +3133     
  Branches        26922    27694     +772     
==============================================
+ Hits           159003   161915    +2912     
- Misses          40244    40445     +201     
- Partials         8754     8774      +20     
Files Changed Coverage Δ
.../compiler/bir/codegen/methodgen/MainMethodGen.java 97.28% <100.00%> (+0.05%) ⬆️
...lang/compiler/semantics/analyzer/TypeResolver.java 89.32% <100.00%> (-0.09%) ⬇️
...lerinalang/diagramutil/SyntaxTreeMapGenerator.java 89.00% <100.00%> (+0.11%) ⬆️

... and 24 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Jul 29, 2023
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Closed PR due to inactivity for more than 18 days.

@github-actions github-actions bot closed this Aug 1, 2023
@gabilang gabilang removed the Stale label Aug 4, 2023
@gabilang gabilang reopened this Aug 4, 2023
@github-actions
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Aug 19, 2023
@gabilang gabilang removed the Stale label Aug 21, 2023
@Nadeeshan96
Copy link
Contributor

Closing this because this does not contain the latest fix. Instead will merge #41314.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants