Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused rename popup command #40790

Merged
merged 3 commits into from
Jul 6, 2023

Conversation

mindula
Copy link
Contributor

@mindula mindula commented Jun 21, 2023

Purpose

This PR removed the unused rename popup command that used the text position.

Fixes #40632

VSCode plugin PR: https://github.com/wso2-enterprise/ballerina-plugin-vscode/pull/1600

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@mindula mindula added the Team/LanguageServer Language Server Implementation related issues. #Compiler label Jun 21, 2023
@mindula mindula changed the title Removed unused rename popup command Remove unused rename popup command Jun 21, 2023
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (367ee17) 76.44% compared to head (11b1e37) 76.44%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #40790   +/-   ##
=========================================
  Coverage     76.44%   76.44%           
+ Complexity    55213    55210    -3     
=========================================
  Files          3377     3377           
  Lines        208026   208002   -24     
  Branches      26931    26926    -5     
=========================================
- Hits         159017   159012    -5     
+ Misses        40257    40235   -22     
- Partials       8752     8755    +3     
Impacted Files Coverage Δ
...erinalang/langserver/LSClientCapabilitiesImpl.java 62.50% <ø> (-2.28%) ⬇️
.../langserver/common/constants/CommandConstants.java 90.00% <ø> (ø)
...lang/compiler/semantics/analyzer/CodeAnalyzer.java 87.65% <100.00%> (+0.05%) ⬆️
.../compiler/semantics/analyzer/QueryTypeChecker.java 89.12% <100.00%> (+0.05%) ⬆️
.../providers/createvar/CreateVariableCodeAction.java 90.12% <100.00%> (-2.88%) ⬇️
...oviders/createvar/ErrorHandleInsideCodeAction.java 86.36% <100.00%> (-4.95%) ⬇️
...viders/createvar/ErrorHandleOutsideCodeAction.java 95.83% <100.00%> (-2.13%) ⬇️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@malinthar malinthar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@malinthar malinthar merged commit 77a49fc into ballerina-platform:master Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/LanguageServer Language Server Implementation related issues. #Compiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Deprecate/remove unused rename popup commands
3 participants