Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Deprecate/remove unused rename popup commands #40632

Closed
IMS94 opened this issue Jun 8, 2023 · 0 comments · Fixed by #40790
Closed

[Task]: Deprecate/remove unused rename popup commands #40632

IMS94 opened this issue Jun 8, 2023 · 0 comments · Fixed by #40790
Assignees
@mindula
Labels
Area/CodeAction Language Server Code Actions Area/Rename Language Server Rename related issues Points/3 Equivalent to three days effort Team/LanguageServer Language Server Implementation related issues. #Compiler Type/Task
Milestone
2201.8.0

Comments

@IMS94
Copy link
Contributor

IMS94 commented Jun 8, 2023

Description

While implementing the rename popup feature, we first implemented the rename command to use text position. But we came across a bug in it and decided to use line position instead.

The command we introduced for text position is still there and needs to be removed now. Also from the plugin side.

Describe your task(s)

No response

Related area

-> Editor

Related issue(s) (optional)

No response

Suggested label(s) (optional)

No response

Suggested assignee(s) (optional)

No response
@IMS94 IMS94 added the Type/Task label Jun 8, 2023
@ballerina-bot ballerina-bot added needTriage The issue has to be inspected and labeled manually userCategory/Editor labels Jun 8, 2023
@IMS94 IMS94 added Team/LanguageServer Language Server Implementation related issues. #Compiler Area/CodeAction Language Server Code Actions Area/Rename Language Server Rename related issues and removed needTriage The issue has to be inspected and labeled manually userCategory/Editor labels Jun 8, 2023
@malinthar malinthar added the Points/3 Equivalent to three days effort label Jun 8, 2023
@mindula mindula mentioned this issue Jun 21, 2023
Merged
13 tasks
@malinthar malinthar added this to the 2201.8.0 milestone Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mindula mindula

Labels
Area/CodeAction Language Server Code Actions Area/Rename Language Server Rename related issues Points/3 Equivalent to three days effort Team/LanguageServer Language Server Implementation related issues. #Compiler Type/Task
Projects
Ballerina Team Main Board
Archived in project
Milestone
2201.8.0
Development

Successfully merging a pull request may close this issue.

Remove unused rename popup command mindula/ballerina-lang
4 participants
@IMS94 @ballerina-bot @malinthar @mindula