[Master] Fix Invalid type inferring for literal expression

[SasinduDilshara]

Purpose

Fix Invalid type inferring for literal expression.

Fixes #37750
Fixes #38270
Fixes #38498
Fixes #38499

Check List

• Read the Contributing Guide
• Updated Change Log
• Checked Tooling Support (#)
• Added necessary tests
  • Unit Tests
  • Spec Conformance Tests
  • Integration Tests
  • Ballerina By Example Tests
• Increased Test Coverage
• Added necessary documentation
  • API documentation
  • Module documentation in Module.md files
  • Ballerina By Examples

[MaryamZi]

I don't think the fix is correct. Please check the comments on the test changes.

[SasinduDilshara]

I don't think the fix is correct. Please check the comments on the test changes.

will check. Thanks.

[KavinduZoysa]

I think you can pass the compatibleType into this function

ballerina-lang/compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/TypeChecker.java

Line 634 in 4c29c69

return getFiniteTypeMatchWithIntLiteral(literalExpr, finiteType, literalValue, data);

and we can return compatibleType at this point

ballerina-lang/compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/TypeChecker.java

Line 556 in 4c29c69

return symTable.intType;

[SasinduDilshara]

I don't think the fix is correct. Please check the comments on the test changes.

Updated the PR. Please check.

[codecov]

Codecov Report

Patch coverage: 91.74% and no project coverage change.

Comparison is base (e87e53d) 76.35% compared to head (e57a4ab) 76.35%.
Report is 33 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##             master   #38029    +/-   ##
==========================================
  Coverage     76.35%   76.35%            
- Complexity    52258    52301    +43     
==========================================
  Files          2865     2866     +1     
  Lines        197494   197635   +141     
  Branches      25656    25687    +31     
==========================================
+ Hits         150791   150913   +122     
- Misses        38398    38413    +15     
- Partials       8305     8309     +4     

Files Changed	Coverage Δ
.../compiler/semantics/analyzer/DataflowAnalyzer.java	89.87% <50.00%> (-0.08%)	⬇️
...alang/compiler/semantics/analyzer/TypeChecker.java	92.16% <82.60%> (-0.04%)	⬇️
...nalang/formatter/core/ImportFormattingOptions.java	85.00% <85.00%> (ø)
.../compiler/semantics/analyzer/QueryTypeChecker.java	88.74% <94.17%> (+0.69%)	⬆️
...g/ballerinalang/formatter/core/FormatterUtils.java	92.59% <100.00%> (+2.59%)	⬆️
...allerinalang/formatter/core/FormattingOptions.java	50.81% <100.00%> (+4.39%)	⬆️
...inalang/formatter/core/FormattingTreeModifier.java	96.10% <100.00%> (+0.13%)	⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

[github-actions]

Closed PR due to inactivity for more than 18 days.

[pcnfernando]

@SasinduDilshara can you bring this to buldable state

[github-actions]

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

To go ahead with the merge