Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update Reverse Registrar into testnet v0.2.0 #39

Merged
merged 6 commits into from
Oct 13, 2023

Conversation

TuDo1403
Copy link
Collaborator

@TuDo1403 TuDo1403 commented Oct 13, 2023

Description

This PR updates latest feature form 'feature/reverse-registrar` to release-testnet/v0.2.0.

Checklist

  • I have clearly commented on all the main functions following the NatSpec Format
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

TuDo1403 and others added 2 commits October 13, 2023 13:30
…egistrar (#37)

* feat: add Public Resolvers into testnet v0.2.0 (#17)

* forge install: ens-contracts

v0.1

* forge install: buffer

688aa09e9ad241a94609e6af539e65f229912b16

* chore: migrate from private repo

* feat: add PublicResolver & dependency

* fix: outdated name and address in Public Resolver (#5)

fix: outdated name and address in Public Resolver

* fix: resolve merge conflicts

* fix: resolve merge conflicts

---------

Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com>

* feat: add RNSAuction into testnet v0.2.0 (#24)

* feat: implement Auction contract for RNS (#18)

feat: add RNSAuction

* Resolve merge conflict/auction (#25)

* feat: add Public Resolvers into testnet v0.2.0 (#17)

* forge install: ens-contracts

v0.1

* forge install: buffer

688aa09e9ad241a94609e6af539e65f229912b16

* chore: migrate from private repo

* feat: add PublicResolver & dependency

* fix: outdated name and address in Public Resolver (#5)

fix: outdated name and address in Public Resolver

* fix: resolve merge conflicts

* fix: resolve merge conflicts

---------

Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com>

* feat: add RNSAuction

---------

Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com>

---------

Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com>

* feat: add RNSDomainPrice into testnet v0.2.0 (#26)

* feat: add`RNSDomainPrice` contract (#19)

* feat: add RNSDomainPrice

* forge install: pyth-sdk-solidity

v2.2.0

* chore: resolve merge conflict 'feature/domain-price' into release-testnet/v0.2.0 (#27)

* feat: implement Auction contract for RNS (#18)

feat: add RNSAuction

* fix: resolve conflict

* forge install: pyth-sdk-solidity

v2.2.0

* fix: add remapping for @pythnetwork

* chore: resolve confict

* feat: return tax price in `RNSDomainPrice` (#34)

* feat: return usdTax and ronTax

* feat: use struct

---------

Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com>

---------

Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com>
…ar (#33)

feat: reuse LibRNSDomain & LibString and minor refactor
@TuDo1403 TuDo1403 changed the title Feature/reverse registrar feat: update Reverse Registrar into testnet v0.2.0 Oct 13, 2023
…e-testnet/v0.2.0 (#40)

* feat: add Public Resolvers into testnet v0.2.0 (#17)

* forge install: ens-contracts

v0.1

* forge install: buffer

688aa09e9ad241a94609e6af539e65f229912b16

* chore: migrate from private repo

* feat: add PublicResolver & dependency

* fix: outdated name and address in Public Resolver (#5)

fix: outdated name and address in Public Resolver

* fix: resolve merge conflicts

* fix: resolve merge conflicts

---------

Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com>

* feat: add RNSAuction into testnet v0.2.0 (#24)

* feat: implement Auction contract for RNS (#18)

feat: add RNSAuction

* Resolve merge conflict/auction (#25)

* feat: add Public Resolvers into testnet v0.2.0 (#17)

* forge install: ens-contracts

v0.1

* forge install: buffer

688aa09e9ad241a94609e6af539e65f229912b16

* chore: migrate from private repo

* feat: add PublicResolver & dependency

* fix: outdated name and address in Public Resolver (#5)

fix: outdated name and address in Public Resolver

* fix: resolve merge conflicts

* fix: resolve merge conflicts

---------

Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com>

* feat: add RNSAuction

---------

Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com>

---------

Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com>

* feat: add RNSDomainPrice into testnet v0.2.0 (#26)

* feat: add`RNSDomainPrice` contract (#19)

* feat: add RNSDomainPrice

* forge install: pyth-sdk-solidity

v2.2.0

* chore: resolve merge conflict 'feature/domain-price' into release-testnet/v0.2.0 (#27)

* feat: implement Auction contract for RNS (#18)

feat: add RNSAuction

* fix: resolve conflict

* forge install: pyth-sdk-solidity

v2.2.0

* fix: add remapping for @pythnetwork

* chore: resolve confict

* feat: return tax price in `RNSDomainPrice` (#34)

* feat: return usdTax and ronTax

* feat: use struct

---------

Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com>

* refactor: rename vars and check approved or owner for Reverse Registrar

---------

Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com>
@ducthotran2010 ducthotran2010 requested review from a team and ducthotran2010 October 13, 2023 09:00
TuDo1403 and others added 2 commits October 13, 2023 16:19
…e-testnet/v0.2.0 (#40)

* feat: add Public Resolvers into testnet v0.2.0 (#17)

* forge install: ens-contracts

v0.1

* forge install: buffer

688aa09e9ad241a94609e6af539e65f229912b16

* chore: migrate from private repo

* feat: add PublicResolver & dependency

* fix: outdated name and address in Public Resolver (#5)

fix: outdated name and address in Public Resolver

* fix: resolve merge conflicts

* fix: resolve merge conflicts

---------

Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com>

* feat: add RNSAuction into testnet v0.2.0 (#24)

* feat: implement Auction contract for RNS (#18)

feat: add RNSAuction

* Resolve merge conflict/auction (#25)

* feat: add Public Resolvers into testnet v0.2.0 (#17)

* forge install: ens-contracts

v0.1

* forge install: buffer

688aa09e9ad241a94609e6af539e65f229912b16

* chore: migrate from private repo

* feat: add PublicResolver & dependency

* fix: outdated name and address in Public Resolver (#5)

fix: outdated name and address in Public Resolver

* fix: resolve merge conflicts

* fix: resolve merge conflicts

---------

Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com>

* feat: add RNSAuction

---------

Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com>

---------

Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com>

* feat: add RNSDomainPrice into testnet v0.2.0 (#26)

* feat: add`RNSDomainPrice` contract (#19)

* feat: add RNSDomainPrice

* forge install: pyth-sdk-solidity

v2.2.0

* chore: resolve merge conflict 'feature/domain-price' into release-testnet/v0.2.0 (#27)

* feat: implement Auction contract for RNS (#18)

feat: add RNSAuction

* fix: resolve conflict

* forge install: pyth-sdk-solidity

v2.2.0

* fix: add remapping for @pythnetwork

* chore: resolve confict

* feat: return tax price in `RNSDomainPrice` (#34)

* feat: return usdTax and ronTax

* feat: use struct

---------

Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com>

* refactor: rename vars and check approved or owner for Reverse Registrar

---------

Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com>
@TuDo1403 TuDo1403 merged commit fd60700 into release-testnet/v0.2.0 Oct 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants