feat: add RNSDomainPrice into testnet v0.2.0 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add RNSDomainPrice * forge install: pyth-sdk-solidity v2.2.0
3 tasks
…tnet/v0.2.0 (#27) * feat: implement Auction contract for RNS (#18) feat: add RNSAuction * fix: resolve conflict * forge install: pyth-sdk-solidity v2.2.0 * fix: add remapping for @pythnetwork
3 tasks
* feat: return usdTax and ronTax * feat: use struct
ducthotran2010
added a commit
that referenced
this pull request
Oct 13, 2023
* feat: add`RNSDomainPrice` contract (#19) * feat: add RNSDomainPrice * forge install: pyth-sdk-solidity v2.2.0 * chore: resolve merge conflict 'feature/domain-price' into release-testnet/v0.2.0 (#27) * feat: implement Auction contract for RNS (#18) feat: add RNSAuction * fix: resolve conflict * forge install: pyth-sdk-solidity v2.2.0 * fix: add remapping for @pythnetwork * chore: resolve confict * feat: return tax price in `RNSDomainPrice` (#34) * feat: return usdTax and ronTax * feat: use struct --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com>
TuDo1403
added a commit
that referenced
this pull request
Oct 13, 2023
…egistrar (#37) * feat: add Public Resolvers into testnet v0.2.0 (#17) * forge install: ens-contracts v0.1 * forge install: buffer 688aa09e9ad241a94609e6af539e65f229912b16 * chore: migrate from private repo * feat: add PublicResolver & dependency * fix: outdated name and address in Public Resolver (#5) fix: outdated name and address in Public Resolver * fix: resolve merge conflicts * fix: resolve merge conflicts --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * feat: add RNSAuction into testnet v0.2.0 (#24) * feat: implement Auction contract for RNS (#18) feat: add RNSAuction * Resolve merge conflict/auction (#25) * feat: add Public Resolvers into testnet v0.2.0 (#17) * forge install: ens-contracts v0.1 * forge install: buffer 688aa09e9ad241a94609e6af539e65f229912b16 * chore: migrate from private repo * feat: add PublicResolver & dependency * fix: outdated name and address in Public Resolver (#5) fix: outdated name and address in Public Resolver * fix: resolve merge conflicts * fix: resolve merge conflicts --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * feat: add RNSAuction --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * feat: add RNSDomainPrice into testnet v0.2.0 (#26) * feat: add`RNSDomainPrice` contract (#19) * feat: add RNSDomainPrice * forge install: pyth-sdk-solidity v2.2.0 * chore: resolve merge conflict 'feature/domain-price' into release-testnet/v0.2.0 (#27) * feat: implement Auction contract for RNS (#18) feat: add RNSAuction * fix: resolve conflict * forge install: pyth-sdk-solidity v2.2.0 * fix: add remapping for @pythnetwork * chore: resolve confict * feat: return tax price in `RNSDomainPrice` (#34) * feat: return usdTax and ronTax * feat: use struct --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com>
TuDo1403
added a commit
that referenced
this pull request
Oct 13, 2023
…egistrar (#37) * feat: add Public Resolvers into testnet v0.2.0 (#17) * forge install: ens-contracts v0.1 * forge install: buffer 688aa09e9ad241a94609e6af539e65f229912b16 * chore: migrate from private repo * feat: add PublicResolver & dependency * fix: outdated name and address in Public Resolver (#5) fix: outdated name and address in Public Resolver * fix: resolve merge conflicts * fix: resolve merge conflicts --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * feat: add RNSAuction into testnet v0.2.0 (#24) * feat: implement Auction contract for RNS (#18) feat: add RNSAuction * Resolve merge conflict/auction (#25) * feat: add Public Resolvers into testnet v0.2.0 (#17) * forge install: ens-contracts v0.1 * forge install: buffer 688aa09e9ad241a94609e6af539e65f229912b16 * chore: migrate from private repo * feat: add PublicResolver & dependency * fix: outdated name and address in Public Resolver (#5) fix: outdated name and address in Public Resolver * fix: resolve merge conflicts * fix: resolve merge conflicts --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * feat: add RNSAuction --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * feat: add RNSDomainPrice into testnet v0.2.0 (#26) * feat: add`RNSDomainPrice` contract (#19) * feat: add RNSDomainPrice * forge install: pyth-sdk-solidity v2.2.0 * chore: resolve merge conflict 'feature/domain-price' into release-testnet/v0.2.0 (#27) * feat: implement Auction contract for RNS (#18) feat: add RNSAuction * fix: resolve conflict * forge install: pyth-sdk-solidity v2.2.0 * fix: add remapping for @pythnetwork * chore: resolve confict * feat: return tax price in `RNSDomainPrice` (#34) * feat: return usdTax and ronTax * feat: use struct --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com>
TuDo1403
added a commit
that referenced
this pull request
Oct 13, 2023
…e-testnet/v0.2.0 (#40) * feat: add Public Resolvers into testnet v0.2.0 (#17) * forge install: ens-contracts v0.1 * forge install: buffer 688aa09e9ad241a94609e6af539e65f229912b16 * chore: migrate from private repo * feat: add PublicResolver & dependency * fix: outdated name and address in Public Resolver (#5) fix: outdated name and address in Public Resolver * fix: resolve merge conflicts * fix: resolve merge conflicts --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * feat: add RNSAuction into testnet v0.2.0 (#24) * feat: implement Auction contract for RNS (#18) feat: add RNSAuction * Resolve merge conflict/auction (#25) * feat: add Public Resolvers into testnet v0.2.0 (#17) * forge install: ens-contracts v0.1 * forge install: buffer 688aa09e9ad241a94609e6af539e65f229912b16 * chore: migrate from private repo * feat: add PublicResolver & dependency * fix: outdated name and address in Public Resolver (#5) fix: outdated name and address in Public Resolver * fix: resolve merge conflicts * fix: resolve merge conflicts --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * feat: add RNSAuction --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * feat: add RNSDomainPrice into testnet v0.2.0 (#26) * feat: add`RNSDomainPrice` contract (#19) * feat: add RNSDomainPrice * forge install: pyth-sdk-solidity v2.2.0 * chore: resolve merge conflict 'feature/domain-price' into release-testnet/v0.2.0 (#27) * feat: implement Auction contract for RNS (#18) feat: add RNSAuction * fix: resolve conflict * forge install: pyth-sdk-solidity v2.2.0 * fix: add remapping for @pythnetwork * chore: resolve confict * feat: return tax price in `RNSDomainPrice` (#34) * feat: return usdTax and ronTax * feat: use struct --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * refactor: rename vars and check approved or owner for Reverse Registrar --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com>
TuDo1403
added a commit
that referenced
this pull request
Oct 13, 2023
…e-testnet/v0.2.0 (#40) * feat: add Public Resolvers into testnet v0.2.0 (#17) * forge install: ens-contracts v0.1 * forge install: buffer 688aa09e9ad241a94609e6af539e65f229912b16 * chore: migrate from private repo * feat: add PublicResolver & dependency * fix: outdated name and address in Public Resolver (#5) fix: outdated name and address in Public Resolver * fix: resolve merge conflicts * fix: resolve merge conflicts --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * feat: add RNSAuction into testnet v0.2.0 (#24) * feat: implement Auction contract for RNS (#18) feat: add RNSAuction * Resolve merge conflict/auction (#25) * feat: add Public Resolvers into testnet v0.2.0 (#17) * forge install: ens-contracts v0.1 * forge install: buffer 688aa09e9ad241a94609e6af539e65f229912b16 * chore: migrate from private repo * feat: add PublicResolver & dependency * fix: outdated name and address in Public Resolver (#5) fix: outdated name and address in Public Resolver * fix: resolve merge conflicts * fix: resolve merge conflicts --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * feat: add RNSAuction --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * feat: add RNSDomainPrice into testnet v0.2.0 (#26) * feat: add`RNSDomainPrice` contract (#19) * feat: add RNSDomainPrice * forge install: pyth-sdk-solidity v2.2.0 * chore: resolve merge conflict 'feature/domain-price' into release-testnet/v0.2.0 (#27) * feat: implement Auction contract for RNS (#18) feat: add RNSAuction * fix: resolve conflict * forge install: pyth-sdk-solidity v2.2.0 * fix: add remapping for @pythnetwork * chore: resolve confict * feat: return tax price in `RNSDomainPrice` (#34) * feat: return usdTax and ronTax * feat: use struct --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * refactor: rename vars and check approved or owner for Reverse Registrar --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com>
TuDo1403
added a commit
that referenced
this pull request
Oct 13, 2023
…e-testnet/v0.2.0 (#40) * feat: add Public Resolvers into testnet v0.2.0 (#17) * forge install: ens-contracts v0.1 * forge install: buffer 688aa09e9ad241a94609e6af539e65f229912b16 * chore: migrate from private repo * feat: add PublicResolver & dependency * fix: outdated name and address in Public Resolver (#5) fix: outdated name and address in Public Resolver * fix: resolve merge conflicts * fix: resolve merge conflicts --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * feat: add RNSAuction into testnet v0.2.0 (#24) * feat: implement Auction contract for RNS (#18) feat: add RNSAuction * Resolve merge conflict/auction (#25) * feat: add Public Resolvers into testnet v0.2.0 (#17) * forge install: ens-contracts v0.1 * forge install: buffer 688aa09e9ad241a94609e6af539e65f229912b16 * chore: migrate from private repo * feat: add PublicResolver & dependency * fix: outdated name and address in Public Resolver (#5) fix: outdated name and address in Public Resolver * fix: resolve merge conflicts * fix: resolve merge conflicts --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * feat: add RNSAuction --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * feat: add RNSDomainPrice into testnet v0.2.0 (#26) * feat: add`RNSDomainPrice` contract (#19) * feat: add RNSDomainPrice * forge install: pyth-sdk-solidity v2.2.0 * chore: resolve merge conflict 'feature/domain-price' into release-testnet/v0.2.0 (#27) * feat: implement Auction contract for RNS (#18) feat: add RNSAuction * fix: resolve conflict * forge install: pyth-sdk-solidity v2.2.0 * fix: add remapping for @pythnetwork * chore: resolve confict * feat: return tax price in `RNSDomainPrice` (#34) * feat: return usdTax and ronTax * feat: use struct --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * refactor: rename vars and check approved or owner for Reverse Registrar --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com>
TuDo1403
added a commit
that referenced
this pull request
Oct 13, 2023
* chore: pull latest from 'release/testnet/v0.2.0' to feature/reverse-registrar (#37) * feat: add Public Resolvers into testnet v0.2.0 (#17) * forge install: ens-contracts v0.1 * forge install: buffer 688aa09e9ad241a94609e6af539e65f229912b16 * chore: migrate from private repo * feat: add PublicResolver & dependency * fix: outdated name and address in Public Resolver (#5) fix: outdated name and address in Public Resolver * fix: resolve merge conflicts * fix: resolve merge conflicts --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * feat: add RNSAuction into testnet v0.2.0 (#24) * feat: implement Auction contract for RNS (#18) feat: add RNSAuction * Resolve merge conflict/auction (#25) * feat: add Public Resolvers into testnet v0.2.0 (#17) * forge install: ens-contracts v0.1 * forge install: buffer 688aa09e9ad241a94609e6af539e65f229912b16 * chore: migrate from private repo * feat: add PublicResolver & dependency * fix: outdated name and address in Public Resolver (#5) fix: outdated name and address in Public Resolver * fix: resolve merge conflicts * fix: resolve merge conflicts --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * feat: add RNSAuction --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * feat: add RNSDomainPrice into testnet v0.2.0 (#26) * feat: add`RNSDomainPrice` contract (#19) * feat: add RNSDomainPrice * forge install: pyth-sdk-solidity v2.2.0 * chore: resolve merge conflict 'feature/domain-price' into release-testnet/v0.2.0 (#27) * feat: implement Auction contract for RNS (#18) feat: add RNSAuction * fix: resolve conflict * forge install: pyth-sdk-solidity v2.2.0 * fix: add remapping for @pythnetwork * chore: resolve confict * feat: return tax price in `RNSDomainPrice` (#34) * feat: return usdTax and ronTax * feat: use struct --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * refactor: rename vars and check approved or owner for Reverse Registrar (#33) feat: reuse LibRNSDomain & LibString and minor refactor * chore: resolve merge conflict 'feature/reverse-registrar' into release-testnet/v0.2.0 (#40) * feat: add Public Resolvers into testnet v0.2.0 (#17) * forge install: ens-contracts v0.1 * forge install: buffer 688aa09e9ad241a94609e6af539e65f229912b16 * chore: migrate from private repo * feat: add PublicResolver & dependency * fix: outdated name and address in Public Resolver (#5) fix: outdated name and address in Public Resolver * fix: resolve merge conflicts * fix: resolve merge conflicts --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * feat: add RNSAuction into testnet v0.2.0 (#24) * feat: implement Auction contract for RNS (#18) feat: add RNSAuction * Resolve merge conflict/auction (#25) * feat: add Public Resolvers into testnet v0.2.0 (#17) * forge install: ens-contracts v0.1 * forge install: buffer 688aa09e9ad241a94609e6af539e65f229912b16 * chore: migrate from private repo * feat: add PublicResolver & dependency * fix: outdated name and address in Public Resolver (#5) fix: outdated name and address in Public Resolver * fix: resolve merge conflicts * fix: resolve merge conflicts --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * feat: add RNSAuction --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * feat: add RNSDomainPrice into testnet v0.2.0 (#26) * feat: add`RNSDomainPrice` contract (#19) * feat: add RNSDomainPrice * forge install: pyth-sdk-solidity v2.2.0 * chore: resolve merge conflict 'feature/domain-price' into release-testnet/v0.2.0 (#27) * feat: implement Auction contract for RNS (#18) feat: add RNSAuction * fix: resolve conflict * forge install: pyth-sdk-solidity v2.2.0 * fix: add remapping for @pythnetwork * chore: resolve confict * feat: return tax price in `RNSDomainPrice` (#34) * feat: return usdTax and ronTax * feat: use struct --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * refactor: rename vars and check approved or owner for Reverse Registrar --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * resolve conflicts --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com>
TuDo1403
added a commit
that referenced
this pull request
Oct 14, 2023
* chore: pull latest from 'release/testnet/v0.2.0' to feature/reverse-registrar (#37) * feat: add Public Resolvers into testnet v0.2.0 (#17) * forge install: ens-contracts v0.1 * forge install: buffer 688aa09e9ad241a94609e6af539e65f229912b16 * chore: migrate from private repo * feat: add PublicResolver & dependency * fix: outdated name and address in Public Resolver (#5) fix: outdated name and address in Public Resolver * fix: resolve merge conflicts * fix: resolve merge conflicts --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * feat: add RNSAuction into testnet v0.2.0 (#24) * feat: implement Auction contract for RNS (#18) feat: add RNSAuction * Resolve merge conflict/auction (#25) * feat: add Public Resolvers into testnet v0.2.0 (#17) * forge install: ens-contracts v0.1 * forge install: buffer 688aa09e9ad241a94609e6af539e65f229912b16 * chore: migrate from private repo * feat: add PublicResolver & dependency * fix: outdated name and address in Public Resolver (#5) fix: outdated name and address in Public Resolver * fix: resolve merge conflicts * fix: resolve merge conflicts --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * feat: add RNSAuction --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * feat: add RNSDomainPrice into testnet v0.2.0 (#26) * feat: add`RNSDomainPrice` contract (#19) * feat: add RNSDomainPrice * forge install: pyth-sdk-solidity v2.2.0 * chore: resolve merge conflict 'feature/domain-price' into release-testnet/v0.2.0 (#27) * feat: implement Auction contract for RNS (#18) feat: add RNSAuction * fix: resolve conflict * forge install: pyth-sdk-solidity v2.2.0 * fix: add remapping for @pythnetwork * chore: resolve confict * feat: return tax price in `RNSDomainPrice` (#34) * feat: return usdTax and ronTax * feat: use struct --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * refactor: rename vars and check approved or owner for Reverse Registrar (#33) feat: reuse LibRNSDomain & LibString and minor refactor * chore: resolve merge conflict 'feature/reverse-registrar' into release-testnet/v0.2.0 (#40) * feat: add Public Resolvers into testnet v0.2.0 (#17) * forge install: ens-contracts v0.1 * forge install: buffer 688aa09e9ad241a94609e6af539e65f229912b16 * chore: migrate from private repo * feat: add PublicResolver & dependency * fix: outdated name and address in Public Resolver (#5) fix: outdated name and address in Public Resolver * fix: resolve merge conflicts * fix: resolve merge conflicts --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * feat: add RNSAuction into testnet v0.2.0 (#24) * feat: implement Auction contract for RNS (#18) feat: add RNSAuction * Resolve merge conflict/auction (#25) * feat: add Public Resolvers into testnet v0.2.0 (#17) * forge install: ens-contracts v0.1 * forge install: buffer 688aa09e9ad241a94609e6af539e65f229912b16 * chore: migrate from private repo * feat: add PublicResolver & dependency * fix: outdated name and address in Public Resolver (#5) fix: outdated name and address in Public Resolver * fix: resolve merge conflicts * fix: resolve merge conflicts --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * feat: add RNSAuction --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * feat: add RNSDomainPrice into testnet v0.2.0 (#26) * feat: add`RNSDomainPrice` contract (#19) * feat: add RNSDomainPrice * forge install: pyth-sdk-solidity v2.2.0 * chore: resolve merge conflict 'feature/domain-price' into release-testnet/v0.2.0 (#27) * feat: implement Auction contract for RNS (#18) feat: add RNSAuction * fix: resolve conflict * forge install: pyth-sdk-solidity v2.2.0 * fix: add remapping for @pythnetwork * chore: resolve confict * feat: return tax price in `RNSDomainPrice` (#34) * feat: return usdTax and ronTax * feat: use struct --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * refactor: rename vars and check approved or owner for Reverse Registrar --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * resolve conflicts * Merge branch 'release-testnet/v0.2.0' into feature/reverse-registrar * fix: fix wrong logic RNSReverseRegistrar::_requireLive --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com>
TuDo1403
added a commit
that referenced
this pull request
Oct 15, 2023
* chore: pull latest from 'release/testnet/v0.2.0' to feature/reverse-registrar (#37) * feat: add Public Resolvers into testnet v0.2.0 (#17) * forge install: ens-contracts v0.1 * forge install: buffer 688aa09e9ad241a94609e6af539e65f229912b16 * chore: migrate from private repo * feat: add PublicResolver & dependency * fix: outdated name and address in Public Resolver (#5) fix: outdated name and address in Public Resolver * fix: resolve merge conflicts * fix: resolve merge conflicts --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * feat: add RNSAuction into testnet v0.2.0 (#24) * feat: implement Auction contract for RNS (#18) feat: add RNSAuction * Resolve merge conflict/auction (#25) * feat: add Public Resolvers into testnet v0.2.0 (#17) * forge install: ens-contracts v0.1 * forge install: buffer 688aa09e9ad241a94609e6af539e65f229912b16 * chore: migrate from private repo * feat: add PublicResolver & dependency * fix: outdated name and address in Public Resolver (#5) fix: outdated name and address in Public Resolver * fix: resolve merge conflicts * fix: resolve merge conflicts --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * feat: add RNSAuction --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * feat: add RNSDomainPrice into testnet v0.2.0 (#26) * feat: add`RNSDomainPrice` contract (#19) * feat: add RNSDomainPrice * forge install: pyth-sdk-solidity v2.2.0 * chore: resolve merge conflict 'feature/domain-price' into release-testnet/v0.2.0 (#27) * feat: implement Auction contract for RNS (#18) feat: add RNSAuction * fix: resolve conflict * forge install: pyth-sdk-solidity v2.2.0 * fix: add remapping for @pythnetwork * chore: resolve confict * feat: return tax price in `RNSDomainPrice` (#34) * feat: return usdTax and ronTax * feat: use struct --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * refactor: rename vars and check approved or owner for Reverse Registrar (#33) feat: reuse LibRNSDomain & LibString and minor refactor * chore: resolve merge conflict 'feature/reverse-registrar' into release-testnet/v0.2.0 (#40) * feat: add Public Resolvers into testnet v0.2.0 (#17) * forge install: ens-contracts v0.1 * forge install: buffer 688aa09e9ad241a94609e6af539e65f229912b16 * chore: migrate from private repo * feat: add PublicResolver & dependency * fix: outdated name and address in Public Resolver (#5) fix: outdated name and address in Public Resolver * fix: resolve merge conflicts * fix: resolve merge conflicts --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * feat: add RNSAuction into testnet v0.2.0 (#24) * feat: implement Auction contract for RNS (#18) feat: add RNSAuction * Resolve merge conflict/auction (#25) * feat: add Public Resolvers into testnet v0.2.0 (#17) * forge install: ens-contracts v0.1 * forge install: buffer 688aa09e9ad241a94609e6af539e65f229912b16 * chore: migrate from private repo * feat: add PublicResolver & dependency * fix: outdated name and address in Public Resolver (#5) fix: outdated name and address in Public Resolver * fix: resolve merge conflicts * fix: resolve merge conflicts --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * feat: add RNSAuction --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * feat: add RNSDomainPrice into testnet v0.2.0 (#26) * feat: add`RNSDomainPrice` contract (#19) * feat: add RNSDomainPrice * forge install: pyth-sdk-solidity v2.2.0 * chore: resolve merge conflict 'feature/domain-price' into release-testnet/v0.2.0 (#27) * feat: implement Auction contract for RNS (#18) feat: add RNSAuction * fix: resolve conflict * forge install: pyth-sdk-solidity v2.2.0 * fix: add remapping for @pythnetwork * chore: resolve confict * feat: return tax price in `RNSDomainPrice` (#34) * feat: return usdTax and ronTax * feat: use struct --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * refactor: rename vars and check approved or owner for Reverse Registrar --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * resolve conflicts * Merge branch 'release-testnet/v0.2.0' into feature/reverse-registrar * fix: fix wrong logic RNSReverseRegistrar::_requireLive * fix: fix memory out of gas issue --------- Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds feature RNSDomainPrice contract to release branch.
Checklist