Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: RNS Libraries #20

Closed
wants to merge 10 commits into from

Conversation

TuDo1403
Copy link
Collaborator

Description

This PR setup libraries and dependcies for upcoming features.

Changes

Combine LibSubString, LibStrAddrConvert, StringUtils into LibRNSDomain

Checklist

  • I have clearly commented on all the main functions following the NatSpec Format
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

@TuDo1403 TuDo1403 changed the title Implement-feature/rns-lib Feature: RNS Libraries Oct 11, 2023
@TuDo1403 TuDo1403 marked this pull request as ready for review October 11, 2023 10:09
@TuDo1403 TuDo1403 changed the base branch from release-testnet/v0.2.0 to feature/rns-unified October 11, 2023 10:27
* feat: add ReverseRegistrar for RNS

* Memory safe in LibStrAddrConvert.sol

Co-authored-by: Tu Do <18521578@gm.uit.edu.vn>

* Remove unnecessary import in ReverseRegistrar.sol

Co-authored-by: Tu Do <18521578@gm.uit.edu.vn>

* feat: ReverseRegistrar support resolvers (#10)

* refactor: refactor RNSReverseRegistrar

* doc: update comment

* format: reduce override tag

* Update src/ReverseRegistrar.sol

Co-authored-by: Duke.ron <ducthotran2010@gmail.com>

* format: rename contract

---------

Co-authored-by: Tu Do <18521578@gm.uit.edu.vn>
Co-authored-by: TuDo1403 <tudo.dev@gmail.com>
@TuDo1403 TuDo1403 force-pushed the implement-feature/rns-lib branch 2 times, most recently from 3ba1641 to 7bc3f76 Compare October 11, 2023 10:44
@TuDo1403
Copy link
Collaborator Author

closed.

@TuDo1403 TuDo1403 closed this Oct 13, 2023
@TuDo1403 TuDo1403 deleted the implement-feature/rns-lib branch October 17, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants