Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement Reverse Registrar for RNS #9

Merged
merged 10 commits into from
Oct 10, 2023
Merged

feat: Implement Reverse Registrar for RNS #9

merged 10 commits into from
Oct 10, 2023

Conversation

ducthotran2010
Copy link
Collaborator

@ducthotran2010 ducthotran2010 commented Oct 5, 2023 •
edited
Loading

Description

I focuses on implementing the Reverse Registrar for RNS and adds support for the EIP-181 standard. The Reverse Registrar allows reverse resolution of EVM addresses to RNS names.

The EIP-181 standard, as defined in the Ethereum Improvement Proposals (EIPs), provides a unified and standardized interface for reverse resolution functionality. More information about EIP-181 can be found at https://eips.ethereum.org/EIPS/eip-181.

Changes:

  • Implemented the Reverse Registrar for RNS.
  • Added support for the EIP-181 standard.

Checklist

  • I have clearly commented on all the main functions following the NatSpec Format
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

TuDo1403
TuDo1403 requested changes Oct 5, 2023
View reviewed changes
src/ReverseRegistrar.sol Outdated Show resolved Hide resolved
src/ReverseRegistrar.sol Outdated Show resolved Hide resolved
src/ReverseRegistrar.sol Outdated Show resolved Hide resolved
src/libraries/LibStrAddrConvert.sol Outdated Show resolved Hide resolved
src/libraries/LibStrAddrConvert.sol Outdated Show resolved Hide resolved
src/libraries/LibStrAddrConvert.sol Show resolved Hide resolved
src/libraries/LibStrAddrConvert.sol Outdated Show resolved Hide resolved
ducthotran2010 and others added 2 commits October 5, 2023 18:10
@ducthotran2010
Memory safe in LibStrAddrConvert.sol
251399d 
Co-authored-by: Tu Do <18521578@gm.uit.edu.vn>
@ducthotran2010
Remove unnecessary import in ReverseRegistrar.sol
3e5f6d0 
Co-authored-by: Tu Do <18521578@gm.uit.edu.vn>
TuDo1403
TuDo1403 approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@TuDo1403 TuDo1403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ducthotran2010 ducthotran2010 merged commit f03cd7c into feature/reverse-registrar Oct 10, 2023
1 check passed
@ducthotran2010 ducthotran2010 deleted the implement-feature/reverse-registrar branch October 10, 2023 04:21
TuDo1403 added a commit that referenced this pull request Oct 11, 2023
@ducthotran2010 @TuDo1403
feat: Implement Reverse Registrar for RNS (#9)
9c78543 
* feat: add ReverseRegistrar for RNS

* Memory safe in LibStrAddrConvert.sol

Co-authored-by: Tu Do <18521578@gm.uit.edu.vn>

* Remove unnecessary import in ReverseRegistrar.sol

Co-authored-by: Tu Do <18521578@gm.uit.edu.vn>

* feat: ReverseRegistrar support resolvers (#10)

* refactor: refactor RNSReverseRegistrar

* doc: update comment

* format: reduce override tag

* Update src/ReverseRegistrar.sol

Co-authored-by: Duke.ron <ducthotran2010@gmail.com>

* format: rename contract

---------

Co-authored-by: Tu Do <18521578@gm.uit.edu.vn>
Co-authored-by: TuDo1403 <tudo.dev@gmail.com>
TuDo1403 added a commit that referenced this pull request Oct 11, 2023
@ducthotran2010 @TuDo1403
feat: Implement Reverse Registrar for RNS (#9)
fad9c91 
* feat: add ReverseRegistrar for RNS

* Memory safe in LibStrAddrConvert.sol

Co-authored-by: Tu Do <18521578@gm.uit.edu.vn>

* Remove unnecessary import in ReverseRegistrar.sol

Co-authored-by: Tu Do <18521578@gm.uit.edu.vn>

* feat: ReverseRegistrar support resolvers (#10)

* refactor: refactor RNSReverseRegistrar

* doc: update comment

* format: reduce override tag

* Update src/ReverseRegistrar.sol

Co-authored-by: Duke.ron <ducthotran2010@gmail.com>

* format: rename contract

---------

Co-authored-by: Tu Do <18521578@gm.uit.edu.vn>
Co-authored-by: TuDo1403 <tudo.dev@gmail.com>
TuDo1403 added a commit that referenced this pull request Oct 11, 2023
@ducthotran2010 @TuDo1403
feat: Implement Reverse Registrar for RNS (#9)
6a41fc2 
* feat: add ReverseRegistrar for RNS

* Memory safe in LibStrAddrConvert.sol

Co-authored-by: Tu Do <18521578@gm.uit.edu.vn>

* Remove unnecessary import in ReverseRegistrar.sol

Co-authored-by: Tu Do <18521578@gm.uit.edu.vn>

* feat: ReverseRegistrar support resolvers (#10)

* refactor: refactor RNSReverseRegistrar

* doc: update comment

* format: reduce override tag

* Update src/ReverseRegistrar.sol

Co-authored-by: Duke.ron <ducthotran2010@gmail.com>

* format: rename contract

---------

Co-authored-by: Tu Do <18521578@gm.uit.edu.vn>
Co-authored-by: TuDo1403 <tudo.dev@gmail.com>
TuDo1403 added a commit that referenced this pull request Oct 11, 2023
@ducthotran2010 @TuDo1403
feat: Implement Reverse Registrar for RNS (#9)
861a62c 
* feat: add ReverseRegistrar for RNS

* Memory safe in LibStrAddrConvert.sol

Co-authored-by: Tu Do <18521578@gm.uit.edu.vn>

* Remove unnecessary import in ReverseRegistrar.sol

Co-authored-by: Tu Do <18521578@gm.uit.edu.vn>

* feat: ReverseRegistrar support resolvers (#10)

* refactor: refactor RNSReverseRegistrar

* doc: update comment

* format: reduce override tag

* Update src/ReverseRegistrar.sol

Co-authored-by: Duke.ron <ducthotran2010@gmail.com>

* format: rename contract

---------

Co-authored-by: Tu Do <18521578@gm.uit.edu.vn>
Co-authored-by: TuDo1403 <tudo.dev@gmail.com>
TuDo1403 added a commit that referenced this pull request Oct 11, 2023
@ducthotran2010 @TuDo1403
feat: Implement Reverse Registrar for RNS (#9)
0417f20 
* feat: add ReverseRegistrar for RNS

* Memory safe in LibStrAddrConvert.sol

Co-authored-by: Tu Do <18521578@gm.uit.edu.vn>

* Remove unnecessary import in ReverseRegistrar.sol

Co-authored-by: Tu Do <18521578@gm.uit.edu.vn>

* feat: ReverseRegistrar support resolvers (#10)

* refactor: refactor RNSReverseRegistrar

* doc: update comment

* format: reduce override tag

* Update src/ReverseRegistrar.sol

Co-authored-by: Duke.ron <ducthotran2010@gmail.com>

* format: rename contract

---------

Co-authored-by: Tu Do <18521578@gm.uit.edu.vn>
Co-authored-by: TuDo1403 <tudo.dev@gmail.com>
TuDo1403 added a commit that referenced this pull request Oct 11, 2023
@ducthotran2010 @TuDo1403
feat: Implement Reverse Registrar for RNS (#9)
00e53a8 
* feat: add ReverseRegistrar for RNS

* Memory safe in LibStrAddrConvert.sol

Co-authored-by: Tu Do <18521578@gm.uit.edu.vn>

* Remove unnecessary import in ReverseRegistrar.sol

Co-authored-by: Tu Do <18521578@gm.uit.edu.vn>

* feat: ReverseRegistrar support resolvers (#10)

* refactor: refactor RNSReverseRegistrar

* doc: update comment

* format: reduce override tag

* Update src/ReverseRegistrar.sol

Co-authored-by: Duke.ron <ducthotran2010@gmail.com>

* format: rename contract

---------

Co-authored-by: Tu Do <18521578@gm.uit.edu.vn>
Co-authored-by: TuDo1403 <tudo.dev@gmail.com>
TuDo1403 added a commit that referenced this pull request Oct 11, 2023
@ducthotran2010 @TuDo1403
feat: Implement Reverse Registrar for RNS (#9)
c37be55 
* feat: add ReverseRegistrar for RNS

* Memory safe in LibStrAddrConvert.sol

Co-authored-by: Tu Do <18521578@gm.uit.edu.vn>

* Remove unnecessary import in ReverseRegistrar.sol

Co-authored-by: Tu Do <18521578@gm.uit.edu.vn>

* feat: ReverseRegistrar support resolvers (#10)

* refactor: refactor RNSReverseRegistrar

* doc: update comment

* format: reduce override tag

* Update src/ReverseRegistrar.sol

Co-authored-by: Duke.ron <ducthotran2010@gmail.com>

* format: rename contract

---------

Co-authored-by: Tu Do <18521578@gm.uit.edu.vn>
Co-authored-by: TuDo1403 <tudo.dev@gmail.com>
TuDo1403 added a commit that referenced this pull request Oct 11, 2023
@ducthotran2010 @TuDo1403
feat: Implement Reverse Registrar for RNS (#9)
99cecc7 
* feat: add ReverseRegistrar for RNS

* Memory safe in LibStrAddrConvert.sol

Co-authored-by: Tu Do <18521578@gm.uit.edu.vn>

* Remove unnecessary import in ReverseRegistrar.sol

Co-authored-by: Tu Do <18521578@gm.uit.edu.vn>

* feat: ReverseRegistrar support resolvers (#10)

* refactor: refactor RNSReverseRegistrar

* doc: update comment

* format: reduce override tag

* Update src/ReverseRegistrar.sol

Co-authored-by: Duke.ron <ducthotran2010@gmail.com>

* format: rename contract

---------

Co-authored-by: Tu Do <18521578@gm.uit.edu.vn>
Co-authored-by: TuDo1403 <tudo.dev@gmail.com>
TuDo1403 added a commit that referenced this pull request Oct 11, 2023
@ducthotran2010 @TuDo1403
feat: Implement Reverse Registrar for RNS (#9)
047f4e1 
* feat: add ReverseRegistrar for RNS

* Memory safe in LibStrAddrConvert.sol

Co-authored-by: Tu Do <18521578@gm.uit.edu.vn>

* Remove unnecessary import in ReverseRegistrar.sol

Co-authored-by: Tu Do <18521578@gm.uit.edu.vn>

* feat: ReverseRegistrar support resolvers (#10)

* refactor: refactor RNSReverseRegistrar

* doc: update comment

* format: reduce override tag

* Update src/ReverseRegistrar.sol

Co-authored-by: Duke.ron <ducthotran2010@gmail.com>

* format: rename contract

---------

Co-authored-by: Tu Do <18521578@gm.uit.edu.vn>
Co-authored-by: TuDo1403 <tudo.dev@gmail.com>
TuDo1403 pushed a commit that referenced this pull request Oct 12, 2023
@ducthotran2010
feat: pull latest code from branch release to resolve conflict (#23)
fc170d1 
* feat: add expiry check

* format: add doc

* feat: remove TTL & minor improvements (#8)

* feat: remove TTL & minor improvements

* chore: fix rebase issue

* feat: add RNSUnified.mint tests

* fix: rebase issue

* feat: add setExpiry tests

* feat: add overriden ERC721 unit tests

* fix: add bulkSetProtected tests

* feat: add exists check and minor tests update

* feat: minor bug fix and more unit tests for setRecord

* feat: resolve issue setRecord owner

* feat: add event check

* fix: fix revert wrong error code

* fix: minor bug fix and refactor tests

* fix: setRecord expiry

* feat: remove arg in error

* fix: fix test

* fix: resolve issues

* format: add notice comment

* Update src/RNSUnified.sol

Co-authored-by: Duke.ron <ducthotran2010@gmail.com>

* Update src/RNSUnified.sol

Co-authored-by: Duke.ron <ducthotran2010@gmail.com>

* Update src/RNSUnified.sol

Co-authored-by: Duke.ron <ducthotran2010@gmail.com>

* format: rename shouldUpdateProtected to shouldRemoveProtected

* override ERC721::_transfer, ERC721::_burn

* doc: update comment

* fix: only remove record.mut

* feat: Implement Reverse Registrar for RNS (#9)

* feat: add ReverseRegistrar for RNS

* Memory safe in LibStrAddrConvert.sol

Co-authored-by: Tu Do <18521578@gm.uit.edu.vn>

* Remove unnecessary import in ReverseRegistrar.sol

Co-authored-by: Tu Do <18521578@gm.uit.edu.vn>

* feat: ReverseRegistrar support resolvers (#10)

* refactor: refactor RNSReverseRegistrar

* doc: update comment

* format: reduce override tag

* Update src/ReverseRegistrar.sol

Co-authored-by: Duke.ron <ducthotran2010@gmail.com>

* format: rename contract

---------

Co-authored-by: Tu Do <18521578@gm.uit.edu.vn>
Co-authored-by: TuDo1403 <tudo.dev@gmail.com>

* fix: ownerOf return address(0) instead of revert

* format: minor format

---------

Co-authored-by: Duke.ron <ducthotran2010@gmail.com>
ducthotran2010 added a commit that referenced this pull request Oct 13, 2023
@ducthotran2010 @TuDo1403
feat: Implement Reverse Registrar for RNS (#9)
0f2473c 
* feat: add ReverseRegistrar for RNS

* Memory safe in LibStrAddrConvert.sol

Co-authored-by: Tu Do <18521578@gm.uit.edu.vn>

* Remove unnecessary import in ReverseRegistrar.sol

Co-authored-by: Tu Do <18521578@gm.uit.edu.vn>

* feat: ReverseRegistrar support resolvers (#10)

* refactor: refactor RNSReverseRegistrar

* doc: update comment

* format: reduce override tag

* Update src/ReverseRegistrar.sol

Co-authored-by: Duke.ron <ducthotran2010@gmail.com>

* format: rename contract

---------

Co-authored-by: Tu Do <18521578@gm.uit.edu.vn>
Co-authored-by: TuDo1403 <tudo.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TuDo1403 TuDo1403 TuDo1403 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ducthotran2010 @TuDo1403