Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky prefetcher unit tests #28

Closed
wants to merge 1 commit into from
Closed

Fix flaky prefetcher unit tests #28

wants to merge 1 commit into from

Conversation

rdpsin
Copy link
Contributor

@rdpsin rdpsin commented Aug 19, 2022

The prefetcher unit tests were failing because of uninitialized garbage
data when deserializing the dictionaries from the binary blob.

Signed-off-by: Rishabh Singhvi rdpsin@amazon.com

Issue #, if available:
Fixes #24

Description of changes:

Testing performed:

Before :

$ for i in {0..100}; do go clean -testcache; go test ./...; echo $?; done | grep 1 | wc -l
17

After:

$ for i in {0..100}; do go clean -testcache; go test ./...; echo $?; done | grep 1 | wc -l
0

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The prefetcher unit tests were failing because of uninitialized garbage
data when deserializing the dictionaries from the binary blob.

Signed-off-by: Rishabh Singhvi <rdpsin@amazon.com>
@rdpsin rdpsin requested a review from a team as a code owner August 19, 2022 18:10
@rdpsin rdpsin closed this Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prefetch unit tests are flaky
1 participant