Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefetch unit tests are flaky #24

Closed
rdpsin opened this issue Aug 17, 2022 · 0 comments · Fixed by #29
Closed

Prefetch unit tests are flaky #24

rdpsin opened this issue Aug 17, 2022 · 0 comments · Fixed by #29
Labels
bug Something isn't working

Comments

@rdpsin
Copy link
Contributor

rdpsin commented Aug 17, 2022

Describe the bug
The prefetcher unit tests randomly fail with the error: spans digest do not match.

Steps To Reproduce

  • cd into fs

  • Run the tests multiple times.

$ go clean -testcache && go test ./...

ok      github.com/awslabs/soci-snapshotter/fs    0.009s
?       github.com/awslabs/soci-snapshotter/fs/config    [no test files]
ok      github.com/awslabs/soci-snapshotter/fs/layer    8.559s
?       github.com/awslabs/soci-snapshotter/fs/metrics/common    [no test files]
?       github.com/awslabs/soci-snapshotter/fs/metrics/layer    [no test files]
ok      github.com/awslabs/soci-snapshotter/fs/reader    3.878s
ok      github.com/awslabs/soci-snapshotter/fs/remote    12.936s
?       github.com/awslabs/soci-snapshotter/fs/source    [no test files]
ok      github.com/awslabs/soci-snapshotter/fs/span-manager    0.629s

$ go clean -testcache && go test ./...
ok      github.com/awslabs/soci-snapshotter/fs    0.008s
?       github.com/awslabs/soci-snapshotter/fs/config    [no test files]
ok      github.com/awslabs/soci-snapshotter/fs/layer    8.671s
?       github.com/awslabs/soci-snapshotter/fs/metrics/common    [no test files]
?       github.com/awslabs/soci-snapshotter/fs/metrics/layer    [no test files]
ok      github.com/awslabs/soci-snapshotter/fs/reader    3.910s
ok      github.com/awslabs/soci-snapshotter/fs/remote    12.939s
?       github.com/awslabs/soci-snapshotter/fs/source    [no test files]
--- FAIL: TestStateTransition (0.00s)
    --- FAIL: TestStateTransition/max_span_-_prefetch (0.00s)
        span_manager_test.go:211: failed resolving the span for prefetch
    --- FAIL: TestStateTransition/max_span_-_on_demand_fetch (0.00s)
        span_manager_test.go:220: failed getting the span for on-demand fetch
FAIL
FAIL    github.com/awslabs/soci-snapshotter/fs/span-manager    0.631s
FAIL

Expected behavior
The prefetcher unit tests pass consistently.

Configuration (please complete the following information):

  • OS: N/A
  • Snapshotter Version: Commit ID #714f1a971e6
  • Containerd Version: N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix flaky prefetcher unit tests
Fix flaky prefetcher unit tests
1 participant
@rdpsin