Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(firehose-destinations-alpha): support zero buffering #28716

Merged
merged 3 commits into from
Jan 16, 2024
Merged

feat(firehose-destinations-alpha): support zero buffering #28716

merged 3 commits into from
Jan 16, 2024

Conversation

humanzz
Copy link
Contributor

@humanzz humanzz commented Jan 15, 2024 •
edited
Loading

support zero buffering (announcement, documentation)

Closes #28714

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team January 15, 2024 20:34
@github-actions github-actions bot added feature-request A feature should be added or improved. p2 admired-contributor [Pilot] contributed between 13-24 PRs to the CDK labels Jan 15, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@humanzz
Copy link
Contributor Author

humanzz commented Jan 15, 2024 •
edited
Loading

Exemption Request
Package README does not have details as it's deferring to the main firehose's package README

@aws-cdk-automation aws-cdk-automation added pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. and removed pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run labels Jan 15, 2024
@humanzz humanzz mentioned this pull request Jan 15, 2024
Closed
scanlonp
scanlonp requested changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@scanlonp scanlonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one small change.

Also, you can add a line in the kinesisfirehose readme about this feature. There is a section on buffering there.

packages/@aws-cdk/aws-kinesisfirehose-destinations-alpha/lib/private/helpers.ts Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jan 16, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 16, 2024 19:13

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@humanzz
Copy link
Contributor Author

humanzz commented Jan 16, 2024

@scanlonp

Looks good. Just one small change.

Also, you can add a line in the kinesisfirehose readme about this feature. There is a section on buffering there.

Updated README in update aws-kinesisfirehose-alpha's README

Responded to comment abt lower bound inline.

scanlonp
scanlonp approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@scanlonp scanlonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition!

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 16, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f60967b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit db2e78e into aws:main Jan 16, 2024
9 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 16, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions github-actions bot mentioned this pull request Feb 1, 2024
Closed
This was referenced Feb 10, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scanlonp scanlonp scanlonp approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
admired-contributor [Pilot] contributed between 13-24 PRs to the CDK feature-request A feature should be added or improved. p2 pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kinesisfirehose-destinations-alpha: support firehose zero buffering
3 participants
@humanzz @aws-cdk-automation @scanlonp