Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kinesisfirehose-destinations-alpha: support firehose zero buffering #28714

Closed
1 of 2 tasks
humanzz opened this issue Jan 15, 2024 · 2 comments · Fixed by #28716 · May be fixed by stack-spot/app-handler-functions-template#2, stack-spot/eks-env-ts-template#2 or stack-spot/web-react-deploy#4
Closed
1 of 2 tasks

kinesisfirehose-destinations-alpha: support firehose zero buffering #28714

humanzz opened this issue Jan 15, 2024 · 2 comments · Fixed by #28716 · May be fixed by stack-spot/app-handler-functions-template#2, stack-spot/eks-env-ts-template#2 or stack-spot/web-react-deploy#4
Labels
@aws-cdk/aws-kinesisfirehose Related to Amazon Kinesis Data Firehose effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@humanzz
Copy link
Contributor

humanzz commented Jan 15, 2024 •
edited
Loading

Describe the feature

Firehose released Firehose zero buffering in this announcement (documentation) which allows for setting buffering interval seconds as low as 0 as opposed to the existing minimum of 60 in cdk.

This is a request to allow setting bufferingInterval prop as low as 0.

Use Case

See released feature

Proposed Solution

Update the validation to allow for values as low as 0

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.117.0

Environment details (OS name and version, etc.)

macOS
@humanzz humanzz added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 15, 2024
@github-actions github-actions bot added the @aws-cdk/aws-kinesisfirehose Related to Amazon Kinesis Data Firehose label Jan 15, 2024
@humanzz humanzz mentioned this issue Jan 15, 2024
Merged
@humanzz humanzz changed the title aws-kinesisfirehose-destinations-alpha: support firehose zero buffering kinesisfirehose-destinations-alpha: support firehose zero buffering Jan 15, 2024
@humanzz humanzz mentioned this issue Jan 15, 2024
Closed
@pahud
Copy link
Contributor

pahud commented Jan 16, 2024

Thank you for the PR.

@pahud pahud added effort/medium Medium work item – several days of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels Jan 16, 2024
@mergify mergify bot closed this as completed in #28716 Jan 16, 2024
mergify bot pushed a commit that referenced this issue Jan 16, 2024
@humanzz
feat(firehose-destinations-alpha): support zero buffering (#28716)
db2e78e 
support zero buffering ([announcement](https://aws.amazon.com/about-aws/whats-new/2023/12/amazon-kinesis-data-firehose-zero-buffering/), [documentation](https://docs.aws.amazon.com/firehose/latest/dev/buffering-hints.html))

Closes #28714 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot mentioned this issue Feb 1, 2024
Closed
This was referenced Feb 10, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-kinesisfirehose Related to Amazon Kinesis Data Firehose effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
2 participants
@humanzz @pahud