Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[antithesis] Add initial test setup #1166

Merged
merged 16 commits into from
Aug 21, 2024
Merged

[antithesis] Add initial test setup #1166

merged 16 commits into from
Aug 21, 2024

Conversation

marun
Copy link
Contributor

@marun marun commented May 7, 2024

Why this should be merged

This PR adds the scaffolding required to build images for an antithesis test setup for subnet-evm.

How this works

Adds scripts, dockerfiles and code that comprise the antithesis test setup and its tooling.

How was this tested

New CI job checking workload sanity and construction of the images.

NOTE: Due to the limitations inherent to github actions, validation of image publication and the triggering of antithesis workloads can only be performed once this PR is merged.

TODO

Pre-merge

Post-merge

@marun marun self-assigned this May 7, 2024
@marun marun added the testing This primarly focuses on testing label May 7, 2024
@marun marun force-pushed the antithesis-test-setup branch 2 times, most recently from 1554701 to 6ce5230 Compare May 7, 2024 04:11
@marun marun changed the title [antithesis] Propose initial test setup [antithesis] Add initial test setup May 7, 2024
@marun marun force-pushed the antithesis-test-setup branch 2 times, most recently from 1911af1 to b4379dc Compare May 7, 2024 04:29
@marun marun marked this pull request as ready for review May 7, 2024 04:31
@marun marun force-pushed the antithesis-test-setup branch 2 times, most recently from 8dad27f to 76dd130 Compare May 11, 2024 03:40
@marun marun force-pushed the antithesis-test-setup branch 2 times, most recently from 7fb19f0 to 8823a2d Compare May 13, 2024 20:15
@marun marun marked this pull request as draft May 29, 2024 16:17
@marun marun force-pushed the antithesis-test-setup branch 3 times, most recently from 3487b8c to b415f60 Compare July 19, 2024 08:50
@marun marun marked this pull request as ready for review July 19, 2024 09:00
joshua-kim
joshua-kim previously approved these changes Jul 19, 2024
darioush
darioush previously approved these changes Jul 23, 2024
tests/antithesis/main.go Outdated Show resolved Hide resolved
marun added a commit to ava-labs/avalanchego that referenced this pull request Aug 8, 2024
As per @StephenButtolph's comment:
ava-labs/subnet-evm#1166 (comment)

Co-authored-by: Stephen Buttolph <stephen@avalabs.org>
marun added a commit to ava-labs/avalanchego that referenced this pull request Aug 8, 2024
As per @StephenButtolph's comment:
ava-labs/subnet-evm#1166 (comment)

Co-authored-by: Stephen Buttolph <stephen@avalabs.org>
@marun marun force-pushed the antithesis-test-setup branch 3 times, most recently from 9ceb33b to 553d9a5 Compare August 16, 2024 10:41
@darioush
Copy link
Collaborator

This seems fine to me, also let's get @ceyonur 's approval

Copy link
Collaborator

@ceyonur ceyonur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Do we need to add any of these as required status checks in branch settings?

@marun
Copy link
Contributor Author

marun commented Aug 21, 2024

lgtm. Do we need to add any of these as required status checks in branch settings?

Just the Build Antithesis images workflow.

@ceyonur ceyonur enabled auto-merge (squash) August 21, 2024 15:13
@ceyonur ceyonur merged commit cbca34c into master Aug 21, 2024
13 checks passed
@ceyonur ceyonur deleted the antithesis-test-setup branch August 21, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing This primarly focuses on testing
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants