Skip to content

Commit

Permalink
fixup: Ensure images will be pushed
Browse files Browse the repository at this point in the history
  • Loading branch information
marun committed May 13, 2024
1 parent 84158d3 commit 8823a2d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
6 changes: 5 additions & 1 deletion scripts/build_antithesis_images.sh
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ function build_images {

# Define default build command
local docker_cmd="docker buildx build --build-arg GO_VERSION=${GO_VERSION} --build-arg NODE_IMAGE=${node_image_name}"
if [[ -n "${IMAGE_PREFIX}" ]]; then
# Push images with an image prefix since the prefix defines a registry location
docker_cmd="${docker_cmd} --push"
fi

# Build node image first to allow the workload image to be based on it.
${docker_cmd} --build-arg AVALANCHEGO_NODE_IMAGE="${avalanche_node_image}" -t "${node_image_name}" \
Expand Down Expand Up @@ -102,6 +106,6 @@ git checkout -B "test-${AVALANCHE_VERSION}" "${AVALANCHE_VERSION}"
cd "${SUBNET_EVM_PATH}"

# Build avalanchego node image. Supply an empty tag so the tag can be discovered from the hash of the avalanchego repo.
NODE_ONLY=1 TEST_SETUP=avalanchego IMAGE_PREFIX="${IMAGE_PREFIX}" TAG='' bash -x "${AVALANCHEGO_CLONE_PATH}"/scripts/build_antithesis_images.sh
NODE_ONLY=1 TEST_SETUP=avalanchego TAG='' bash -x "${AVALANCHEGO_CLONE_PATH}"/scripts/build_antithesis_images.sh

build_images antithesis-subnet-evm "${SUBNET_EVM_PATH}/Dockerfile" "antithesis-avalanchego-node:${AVALANCHE_VERSION::8}"
2 changes: 1 addition & 1 deletion scripts/versions.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# shellcheck disable=SC2034

# Don't export them as they're used in the context of other calls
AVALANCHE_VERSION=${AVALANCHE_VERSION:-'ad654210e'}
AVALANCHE_VERSION=${AVALANCHE_VERSION:-'4f4b0af28'}
GINKGO_VERSION=${GINKGO_VERSION:-'v2.2.0'}

# This won't be used, but it's here to make code syncs easier
Expand Down

0 comments on commit 8823a2d

Please sign in to comment.