[antithesis] Enable custom plugin dir for subnet-evm #3305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
marun
force-pushed
the
antithesis-plugin-dir
branch
3 times, most recently
from
6b9c81b
to
721bd9e
Compare
ARR4N
reviewed
Aug 19, 2024
tests/antithesis/compose.go
Outdated
| network.DefaultFlags[config.PluginDirKey] = pluginDirForCompose | ||
| } else { | ||
| // Ensure the plugin dir is not provided so that the default is used | ||
| delete(network.DefaultFlags, config.PluginDirKey) |
There was a problem hiding this comment.
You've already deleted it above, on line 72.
tests/antithesis/compose.go
Outdated
| @@ -61,9 +61,27 @@ func GenerateComposeConfig(network *tmpnet.Network, baseImageName string) error | |||
| return fmt.Errorf("failed to get bootstrap volume path: %w", err) | |||
| } | |||
|
|
|||
| // Save the plugin dir for use with compose configuration and remove it from flags so pluginDir can | |||
There was a problem hiding this comment.
How does this relate to the pluginDir variable set earlier from the environment variable? Why does the flag need to be removed if pluginDir is passed as the third argument to initBootstrapDB()?
marun
force-pushed
the
antithesis-plugin-dir
branch
from
69e02b8
to
e490875
Compare
ARR4N
approved these changes
Aug 19, 2024
StephenButtolph
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
subnet-evm's docker image uses a non-default plugin dir and it needs to be possible to set it for nodes that will run under the antithesis docker compose project.
How this works
How this was tested