Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): disable cache-to option to run health-check from forked branch #5021

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Jul 23, 2024

Description

There is currently an issue where health-check cannot be executed from a PR created in a branch of a forked repository. #4988 (comment)
Therefore, this PR removes the cache-to option from the health-check, allowing users without write permissions to execute the health-check.

Tests performed

https://github.com/autowarefoundation/autoware/actions/runs/10051385473?pr=5021

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
@youtalk youtalk self-assigned this Jul 23, 2024
@youtalk youtalk added type:bug Software flaws or errors. type:github-actions Github actions related. (auto-assigned) tag:run-health-check Run health-check labels Jul 23, 2024
@youtalk youtalk marked this pull request as ready for review July 23, 2024 02:02
@youtalk
Copy link
Member Author

youtalk commented Jul 23, 2024

@xmfcx This PR resolved the issue #4988 (comment).
I've already checked the health-check success with a forked branch.
https://github.com/autowarefoundation/autoware/actions/runs/10051050835

@youtalk
Copy link
Member Author

youtalk commented Jul 23, 2024

And this PR's health-check was also succeeded.

Copy link
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youtalk youtalk merged commit fd8503f into autowarefoundation:main Jul 23, 2024
33 of 34 checks passed
@youtalk youtalk deleted the disable-cache-to branch July 23, 2024 06:38
youtalk added a commit to youtalk/autoware that referenced this pull request Jul 24, 2024
* feat(ci): disable `cache-to` option to run `health-check` from forked branch (autowarefoundation#5021)

disable cache-to

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* feat: add single lidar sensor kit (autowarefoundation#4988)

feat(autoware.repos): add single lidar sensor kit

Signed-off-by: beginningfan <beginning.fan@autocore.ai>
Co-authored-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* fix(docker-build): fix ccache typo (autowarefoundation#5024)

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* feat(docker): no longer download artifacts on `devel` image (autowarefoundation#5023)

not download artifacts on devel

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

---------

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: beginningfan <beginning.fan@autocore.ai>
Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Co-authored-by: beginningfan <103237402+beginningfan@users.noreply.github.com>
Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:run-health-check Run health-check type:bug Software flaws or errors. type:github-actions Github actions related. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants