refactor(docker): use colcon mixin instead of raw --cmake-args args
#4842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
youtalk
changed the title
colcon mixin instead of raw argscolcon mixin instead of raw --cmake-args args
|
|
oguzkaganozt
force-pushed
the
fix-colcon-cmake-args
branch
from
b3f8e6c
to
f2c2497
Compare
|
|
|
@oguzkaganozt I've merged the main branch. Please review this too. |
5 tasks
|
@oguzkaganozt @xmfcx @mitsudome-r Please review it. The test was already passed. https://github.com/autowarefoundation/autoware/actions/runs/9441790559 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
--cmake-args#4828This PR changes to use
colcon mixininstead of listing raw--cmake-argsincolcon build.This ensures that the release build settings,
compile-commands.jsongeneration, andccacheusage are correctly configured in accordance withcolcon build's conventions.https://github.com/colcon/colcon-mixin-repository
Tests performed
https://github.com/autowarefoundation/autoware/actions/runs/9441790559
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.