ci(.pre-commit-config-ansible.yaml): update ansible-lint version #3032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
yukke42
force-pushed
the
update-pre-commit-config-ansible
branch
from
66af780
to
7528bd4
Compare
yukke42
changed the title
|
https://github.com/autowarefoundation/autoware/actions/runs/3470511085/jobs/5798798988
The 2nd error will be fixed but not merged yet. osism/issues#326 I decided to just update to pass the CI error. |
Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
|
@kenji-miyake |
kenji-miyake
approved these changes
Nov 18, 2022
There was a problem hiding this comment.
I'll create another PR to upgrade ansible-lint to v6.8.6 and address warnings of new checks.
For now, v5.4.0 looks good to me if it resolves a bug in #3029.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yukke42 yusuke.muramatsu@tier4.jp
Description
Update ansible-lint version to merge #3029.
This CI error is a bug and it has fixed in ansible/ansible-lint#1859 and v5.4.0
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.