Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): remove unnecessary cppcheck suppresion #7780

Merged

Conversation

veqcc
Copy link
Contributor

@veqcc veqcc commented Jul 2, 2024

Description

Remove uselessOverride and syntaxError warnings.

See cppcheck-daily action: https://github.com/autowarefoundation/autoware.universe/actions/workflows/cppcheck-daily.yaml

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
@veqcc veqcc requested a review from kminoda July 2, 2024 06:16
@veqcc veqcc self-assigned this Jul 2, 2024
Copy link

github-actions bot commented Jul 2, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@veqcc veqcc marked this pull request as ready for review July 2, 2024 06:16
@veqcc veqcc added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 2, 2024
@veqcc
Copy link
Contributor Author

veqcc commented Jul 2, 2024

@kminoda
Now it's ready for being merged since #7768 was merged 👍

@veqcc veqcc requested a review from HansRobo July 3, 2024 00:02
@veqcc
Copy link
Contributor Author

veqcc commented Jul 3, 2024

@kminoda @HansRobo
please!!

@veqcc veqcc merged commit 93a6abf into autowarefoundation:main Jul 4, 2024
23 of 24 checks passed
@veqcc veqcc deleted the chore/update_cppcheck_suppressions branch July 4, 2024 05:02
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
…#7780)

* chore(ci): remove unnecessary cppcheck suppresion

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

* remove syntaxError suppression

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

---------

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Signed-off-by: palas21 <palas21@itu.edu.tr>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
…#7780)

* chore(ci): remove unnecessary cppcheck suppresion

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

* remove syntaxError suppression

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

---------

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
* chore(ci): remove unnecessary cppcheck suppresion

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

* remove syntaxError suppression

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

---------

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Ariiees pushed a commit to Ariiees/autoware.universe that referenced this pull request Jul 22, 2024
…#7780)

* chore(ci): remove unnecessary cppcheck suppresion

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

* remove syntaxError suppression

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

---------

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants