fix(lidar_apollo_segmentation_tvm): add virtual destructor to lidar_apollo_segmentation_tvm #7762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pollo_segmentation_tvm Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
github-actions
bot
added
the
component:perception
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
ambroise-arm
reviewed
Jul 1, 2024
perception/lidar_apollo_segmentation_tvm/include/lidar_apollo_segmentation_tvm/feature_map.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
ambroise-arm
added
the
tag:run-build-and-test-differential
ambroise-arm
approved these changes
Jul 1, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7762 +/- ##
==========================================
- Coverage 28.36% 0.80% -27.57%
==========================================
Files 1584 44 -1540
Lines 115529 2357 -113172
Branches 49251 279 -48972
==========================================
- Hits 32773 19 -32754
+ Misses 73812 2338 -71474
+ Partials 8944 0 -8944
☔ View full report in Codecov by Sentry. |
yhisaki
deleted the
add-virtual-destructor-to-lidar_apollo_segmentation_tvm
branch
palas21
pushed a commit
to palas21/autoware.universe
that referenced
this pull request
Jul 12, 2024
…pollo_segmentation_tvm (autowarefoundation#7762) * fix(lidar_apollo_segmentation_tvm): add virtual destructor to lidar_apollo_segmentation_tvm Signed-off-by: Y.Hisaki <yhisaki31@gmail.com> * small change Signed-off-by: Y.Hisaki <yhisaki31@gmail.com> --------- Signed-off-by: Y.Hisaki <yhisaki31@gmail.com> Signed-off-by: palas21 <palas21@itu.edu.tr>
tby-udel
pushed a commit
to tby-udel/autoware.universe
that referenced
this pull request
Jul 14, 2024
…pollo_segmentation_tvm (autowarefoundation#7762) * fix(lidar_apollo_segmentation_tvm): add virtual destructor to lidar_apollo_segmentation_tvm Signed-off-by: Y.Hisaki <yhisaki31@gmail.com> * small change Signed-off-by: Y.Hisaki <yhisaki31@gmail.com> --------- Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…pollo_segmentation_tvm (#7762) * fix(lidar_apollo_segmentation_tvm): add virtual destructor to lidar_apollo_segmentation_tvm Signed-off-by: Y.Hisaki <yhisaki31@gmail.com> * small change Signed-off-by: Y.Hisaki <yhisaki31@gmail.com> --------- Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
Ariiees
pushed a commit
to Ariiees/autoware.universe
that referenced
this pull request
Jul 22, 2024
…pollo_segmentation_tvm (autowarefoundation#7762) * fix(lidar_apollo_segmentation_tvm): add virtual destructor to lidar_apollo_segmentation_tvm Signed-off-by: Y.Hisaki <yhisaki31@gmail.com> * small change Signed-off-by: Y.Hisaki <yhisaki31@gmail.com> --------- Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related links
https://stackoverflow.com/questions/461203/when-to-use-virtual-destructors
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.