Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(autoware_compare_map_segmentation): prefix package and namespace with autoware #7592

Closed
wants to merge 1 commit into from
Closed

refactor(autoware_compare_map_segmentation): prefix package and namespace with autoware #7592

wants to merge 1 commit into from

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Jun 19, 2024 •
edited
Loading

Description

This PR adds the autoware_ prefix to the package and puts headers in the autoware namespace.

See autowarefoundation/autoware#4569

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@esteve
refactor(autoware_compare_map_segmentation): prefix package and names…
9749edf 
…pace with autoware

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) labels Jun 19, 2024
@esteve esteve mentioned this pull request Jun 19, 2024
Open
@technolojin technolojin mentioned this pull request Jul 19, 2024
Merged
@esteve
Copy link
Contributor Author

esteve commented Aug 7, 2024

Superseded by #8005

@esteve esteve closed this Aug 7, 2024
@esteve esteve deleted the prefix-compare_map_segmentation branch August 7, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amc-nu amc-nu Awaiting requested review from amc-nu amc-nu will be requested when the pull request is marked ready for review amc-nu is a code owner

@badai-nguyen badai-nguyen Awaiting requested review from badai-nguyen badai-nguyen will be requested when the pull request is marked ready for review badai-nguyen is a code owner

@yukkysaito yukkysaito Awaiting requested review from yukkysaito yukkysaito will be requested when the pull request is marked ready for review yukkysaito is a code owner

@anhnv3991 anhnv3991 Awaiting requested review from anhnv3991 anhnv3991 will be requested when the pull request is marked ready for review anhnv3991 is a code owner

@KYabuuchi KYabuuchi Awaiting requested review from KYabuuchi KYabuuchi will be requested when the pull request is marked ready for review KYabuuchi is a code owner

@Motsu-san Motsu-san Awaiting requested review from Motsu-san Motsu-san will be requested when the pull request is marked ready for review Motsu-san is a code owner

@RyuYamamoto RyuYamamoto Awaiting requested review from RyuYamamoto RyuYamamoto will be requested when the pull request is marked ready for review RyuYamamoto is a code owner

@SakodaShintaro SakodaShintaro Awaiting requested review from SakodaShintaro SakodaShintaro will be requested when the pull request is marked ready for review SakodaShintaro is a code owner

@TaikiYamada4 TaikiYamada4 Awaiting requested review from TaikiYamada4 TaikiYamada4 will be requested when the pull request is marked ready for review TaikiYamada4 is a code owner

@YamatoAndo YamatoAndo Awaiting requested review from YamatoAndo YamatoAndo will be requested when the pull request is marked ready for review YamatoAndo is a code owner

Assignees
No one assigned
Labels
component:map Map creation, storage, and loading. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@esteve