Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(autoware_behavior_velocity_detection_area_module): prefix package and namespace with autoware #7466

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Jun 12, 2024

Description

This PR adds the autoware_ prefix to the package and puts headers in the autoware namespace.

Part of:

autowarefoundation/autoware#4569

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@esteve esteve added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 12, 2024
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) labels Jun 12, 2024
@esteve esteve enabled auto-merge (squash) June 12, 2024 10:31
@esteve esteve changed the title refactor(autoware_behavior_velocity_detection_area_module): prefix pa…ckage and namespace with autoware refactor(autoware_behavior_velocity_detection_area_module): prefix package and namespace with autoware Jun 12, 2024
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

…ckage and namespace with autoware

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve esteve force-pushed the prefix-behavior_velocity_detection_area_module branch from 659da76 to d233ac0 Compare June 12, 2024 10:37
@esteve esteve merged commit d532672 into autowarefoundation:main Jun 12, 2024
23 of 24 checks passed
@esteve esteve deleted the prefix-behavior_velocity_detection_area_module branch June 12, 2024 13:56
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
……ckage and namespace with autoware (#7466)

refactor(autoware_behavior_velocity_detection_area_module): prefix package and namespace with autoware

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants