Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(obstacle_cruise_planner)!: add autoware_ prefix #7419

Merged

Conversation

yuki-takagi-66
Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 commented Jun 10, 2024

Description

Add autoware_ prefix to obstacle_cruise_planner.

Part of:

Related links

autowarefoundation/autoware#4569

Tests performed

works well in psim

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jun 10, 2024
@yuki-takagi-66 yuki-takagi-66 marked this pull request as ready for review June 10, 2024 12:46
@yuki-takagi-66 yuki-takagi-66 changed the title Prefix obstacle cruise planner refactor(obstacle_cruise_planner)!: add autoware_ prefix Jun 10, 2024
.github/CODEOWNERS Outdated Show resolved Hide resolved
Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a single comment, LGTM.

@yuki-takagi-66 yuki-takagi-66 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 10, 2024
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
@yuki-takagi-66 yuki-takagi-66 merged commit 822519d into autowarefoundation:main Jun 11, 2024
24 checks passed
@yuki-takagi-66 yuki-takagi-66 deleted the prefix-obstacle_cruise_planner branch June 11, 2024 02:37
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants