Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(crosswalk_traffic_light_estimator)!: add autoware_ prefix #7365

Conversation

yuki-takagi-66
Copy link
Contributor

Description

Add autoware_ prefix to crosswalk_traffic_light_estimator.

Part of:

Related links

autowarefoundation/autoware#4569

Tests performed

works well in psim

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jun 7, 2024
@yuki-takagi-66 yuki-takagi-66 changed the title crosswalk_traffic_light_estimator refactor(crosswalk_traffic_light_estimator)!: add autoware_ prefix Jun 7, 2024
@yuki-takagi-66 yuki-takagi-66 marked this pull request as ready for review June 7, 2024 08:55
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota self-requested a review June 7, 2024 10:26
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
@yuki-takagi-66 yuki-takagi-66 force-pushed the prefix-crosswalk_traffic_light_estimator branch from ffcfd03 to 4fc3be0 Compare June 10, 2024 07:22
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
@yuki-takagi-66 yuki-takagi-66 enabled auto-merge (squash) June 10, 2024 08:03
@yuki-takagi-66 yuki-takagi-66 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 10, 2024
@yuki-takagi-66 yuki-takagi-66 merged commit d37dbb9 into autowarefoundation:main Jun 10, 2024
34 checks passed
@yuki-takagi-66 yuki-takagi-66 deleted the prefix-crosswalk_traffic_light_estimator branch June 10, 2024 13:06
technolojin added a commit to technolojin/autoware.universe that referenced this pull request Jun 12, 2024
technolojin added a commit to technolojin/autoware.universe that referenced this pull request Jun 12, 2024
…refix (autowarefoundation#7365)"

This reverts commit d37dbb9.

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants