Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(occlusion_spot): add autoware prefix #7357

Conversation

maxime-clem
Copy link
Contributor

Description

Add autoware prefix and namespace to the occlusion spot module.

Part of:
autowarefoundation/autoware#4569

Tests performed

Psim

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jun 7, 2024
@maxime-clem maxime-clem added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 7, 2024
@maxime-clem maxime-clem force-pushed the refactor/autoware_prefix-occlusion_spot branch from 190c5a1 to 54cf638 Compare June 10, 2024 00:27
@github-actions github-actions bot removed the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Jun 10, 2024
@maxime-clem maxime-clem enabled auto-merge (squash) June 10, 2024 00:27
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem force-pushed the refactor/autoware_prefix-occlusion_spot branch from 54cf638 to 319b3a6 Compare June 10, 2024 02:38
@maxime-clem maxime-clem merged commit fdea913 into autowarefoundation:main Jun 10, 2024
23 of 24 checks passed
@maxime-clem maxime-clem deleted the refactor/autoware_prefix-occlusion_spot branch June 10, 2024 03:50
@youtalk
Copy link
Member

youtalk commented Jun 10, 2024

@maxime-clem I think it might remain the prefix task.
https://github.com/autowarefoundation/autoware/actions/runs/9442219868/job/26004027036?pr=4845#step:9:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants