Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_velocity_planner_common)!: prefix package and namespace with autoware #7314

Conversation

rej55
Copy link
Contributor

@rej55 rej55 commented Jun 6, 2024

Description

Add autoware_ prefix to behavior_velocity_planner_common.
In addition, I add the autoware_ prefix to namespace in behavior_velocity_** packages.

Related links

Part of:

Tests performed

Tested in planning_simulator

Notes for reviewers

Interface changes

Not applicable.

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@rej55 rej55 force-pushed the refactor/prefix_package_behavior_velocity_planner_common branch 2 times, most recently from 7e7fb6f to dc19c28 Compare June 6, 2024 09:49
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jun 6, 2024
rej55 added 4 commits June 7, 2024 14:59
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
…_velocity_walkway_module

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
@rej55 rej55 force-pushed the refactor/prefix_package_behavior_velocity_planner_common branch from dc19c28 to 97c8ec8 Compare June 7, 2024 05:59
@rej55 rej55 changed the title refactor(behavior_velocity_planner_common): add autoware prefix refactor(behavior_velocity_planner_common): prefix package and namespace with autoware Jun 7, 2024
@rej55 rej55 changed the title refactor(behavior_velocity_planner_common): prefix package and namespace with autoware refactor(behavior_velocity_planner_common)!: prefix package and namespace with autoware Jun 7, 2024
@rej55 rej55 marked this pull request as ready for review June 7, 2024 06:07
@rej55 rej55 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 7, 2024
@rej55 rej55 enabled auto-merge (squash) June 7, 2024 06:20
@shmpwk shmpwk disabled auto-merge June 7, 2024 06:53
@shmpwk shmpwk enabled auto-merge (squash) June 7, 2024 06:53
@shmpwk shmpwk merged commit 6669213 into autowarefoundation:main Jun 7, 2024
36 of 38 checks passed
@rej55 rej55 deleted the refactor/prefix_package_behavior_velocity_planner_common branch June 7, 2024 07:20
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…pace with autoware (#7314)

* refactor(behavior_velocity_planner_common): add autoware prefix

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* refactor(behavior_velocity_planner_common): fix run_out module

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* refactor(behavior_velocity_planner_common): fix for autoware_behavior_velocity_walkway_module

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* refactor(behavior_velocity_planner_common): remove unnecessary using

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

---------

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants